Red Hat Bugzilla – Bug 157106
bmptopnm reports filenames as "Standard Input" when reporting read errors
Last modified: 2013-07-02 19:07:01 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050416 Fedora/1.7.7-2
Description of problem:
bmptopnm reports filenames as "Standard Input" when reporting read errors. Instead, it should report the actual filename.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create an invalid bitmap with "touch invalid.bmp"
2. Execute "bmptopnm invalid.bmp"
Actual Results: bmptopnm prints out:
bmptopnm: Standard Input: read error
Expected Results: bmptopnm prints out:
bmptopnm: invalid.bmp: read error
Created attachment 114100 [details]
The fix is to inverted the condition in an if statement that used strcmp().
I did a quick grep of the tree too look for other bugs like this one. Other
other uses look good. Except there was one suspicious usage in
if (strcmp(cmdline_p->input_filespec, "=") == 0 &&
It should probably be:
if (strcmp(cmdline_p->input_filespec, "-") == 0 &&
I will report this as a separate bug.
Oops! I forgot to include the package version: netpbm-progs-10.27-1