Bug 1573893

Summary: OSPD 12 Undercloud - Infrastructure Provider refresh failed
Product: Red Hat CloudForms Management Engine Reporter: Ido Ovadia <iovadia>
Component: ProvidersAssignee: Scott Seago <sseago>
Status: CLOSED CURRENTRELEASE QA Contact: Ido Ovadia <iovadia>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: cpelland, gblomqui, jfrey, jhardy, maufart, obarenbo, simaishi, sseago
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1574569 1574571 (view as bug list) Environment:
Last Closed: 2018-07-30 14:44:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1540579, 1541700, 1574569, 1574571    
Attachments:
Description Flags
Error refresh
none
evm log - Refresh error none

Description Ido Ovadia 2018-05-02 13:06:10 UTC 
Description of problem:
=======================
OSPD 12 Undercloud - Infrastructure Provider  refresh failed

ERROR -- : [EmsRefresh::Refreshers::EmsRefresherMixin::PartialRefreshError]: no implicit conversion of nil into Hash  Method:[rescue in deliver]

ERROR -- : /var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:50:in `refresh'


Version-Release number of selected component:
=============================================
RHOS 12, CFME 5.8.4.2

How reproducible:
=================
100%

Steps to Reproduce:
===================
1. Deploy RHOS 12 (SSL HA: Undercloud, 3*Controller, 2*Compute)
2. Add Undercloud as Infrastructure provider 
3. Refresh

Actual results:
===============
Refresh Failed with Error -- no implicit conversion of nil into Has

Expected results:
================
Refresh finished successfully

Additional info:
================
Log and screenshots enclosed
Comment 2 Ido Ovadia 2018-05-02 13:08:22 UTC 
Created attachment 1430051 [details]
Error refresh
Comment 3 Ido Ovadia 2018-05-02 13:12:40 UTC 
Created attachment 1430052 [details]
evm log - Refresh error
Comment 4 CFME Bot 2018-05-02 17:47:45 UTC 
https://github.com/ManageIQ/manageiq-providers-openstack/pull/284
Comment 5 CFME Bot 2018-05-03 08:05:17 UTC 
New commit detected on ManageIQ/manageiq-providers-openstack/master:

https://github.com/ManageIQ/manageiq-providers-openstack/commit/018d768333be56716cc7025dd0a4a65ccde16614
commit 018d768333be56716cc7025dd0a4a65ccde16614
Author:     Scott Seago <sseago>
AuthorDate: Wed May  2 13:16:23 2018 -0400
Commit:     Scott Seago <sseago>
CommitDate: Wed May  2 13:16:23 2018 -0400

    bz1573893: duplicate opts hash before modifying in raw_connect_try_ssl

    https://bugzilla.redhat.com/show_bug.cgi?id=1573893

    raw_connect_try_ssl modifies the opts hash (pulling out :ssl_options and then
    using it. This means that if raw_connect_try_ssl is called twice with the
    same opts hash, the second time fails because of the side effect of the first
    call. With this change, the method works on a copy of the hash rather than
    the original

 lib/manageiq/providers/openstack/legacy/openstack_handle/handle.rb | 3 +-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 9 Dave Johnson 2018-07-30 14:44:33 UTC 
Closing this as its already been verified in two z-streams and has test coverage around it.