Bug 1574259
| Summary: | Errors unintentionally reported for snapshot status | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Thomas H.P. Andersen <phomes> | ||||
| Component: | cli | Assignee: | Kaushal <kaushal> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | mainline | CC: | bugs | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glusterfs-v4.1.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-06-20 18:05:40 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Thomas H.P. Andersen
2018-05-02 23:03:38 UTC
Created attachment 1430369 [details]
ignore errors from VOL/ALL
The rfc.sh script does not seem to let me push the patch to gerrit, so I attach it here.
I tried to follow the guide to submit the patch but I get this error from rfc.sh:
$ ./rfc.sh
Running coding guidelines check ...
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE / at ./build-aux/checkpatch.pl line 3102.
[detached HEAD 3cc620f1b] cli/snapshot: ignore errors for snapshot status for ALL/VOL
Date: Thu May 3 00:58:02 2018 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/cli-ignore-errors-vol-all.
error: src refspec 1574259 does not match any.
error: failed to push some refs to 'ssh://phomes.org/glusterfs'
I gave the script this bugs ID (just '1574259') when it requested a bugzilla ID.
The patch is also on my github clone if that helps in any way:
https://github.com/phomes/glusterfs/tree/cli-ignore-errors-vol-all
REVIEW: https://review.gluster.org/19956 (cli/snapshot: ignore errors for snapshot status for ALL/VOL) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/19958 (cli/snapshot: ignore errors for snapshot status for ALL/VOL) posted (#1) for review on master by Thomas H.P. Andersen COMMIT: https://review.gluster.org/19958 committed in master by "Amar Tumballi" <amarts> with a commit message- cli/snapshot: ignore errors for snapshot status for ALL/VOL Currently errors are reported for snapshot status of type ALL and VOL. The intention was to ignore those, but the code gets it wrong. The original condition for ignoring ALL/VOL was removed in Bug 1096610 Change-Id Ifc0ac31d2a9f91e136e87f3b51a629df7dba94e8 And the current logic introduced in Bug 789278 Change-Id I985cea1ef787d239b2632d5a7f467070846f92e4 Change-Id: Ic02ea98fb23b1149264e91b41f2fc2ca916d405f Fixes: bz#1574259 Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report. glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html [2] https://www.gluster.org/pipermail/gluster-users/ |