Bug 1578076
| Summary: | [RFE] Allow custom favicons and images into asset pipeline | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Robb Manes <rmanes> |
| Component: | UI - OPS | Assignee: | Dávid Halász <dhalasz> |
| Status: | CLOSED ERRATA | QA Contact: | Parthvi Vala <pvala> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.9.0 | CC: | anikifor, cpelland, dhalasz, gscott, hkataria, jocarter, lavenel, mhradil, mpovolny, myoder, obarenbo, simaishi |
| Target Milestone: | GA | Keywords: | FutureFeature, RFE |
| Target Release: | 5.11.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 5.11.0.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-12-12 13:33:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | CFME Core | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robb Manes
2018-05-14 18:37:32 UTC
New commit detected on ManageIQ/manageiq-api/master: https://github.com/ManageIQ/manageiq-api/commit/2be8845460d72de55923bfd30c7dfcffafd8c8d3 commit 2be8845460d72de55923bfd30c7dfcffafd8c8d3 Author: Dávid Halász <dhalasz> AuthorDate: Tue Jan 29 16:08:57 2019 -0500 Commit: Dávid Halász <dhalasz> CommitDate: Tue Jan 29 16:08:57 2019 -0500 Expose the favicon URL in the branding info endpoints https://bugzilla.redhat.com/show_bug.cgi?id=1578076 app/controllers/api/api_controller.rb | 3 +- spec/requests/entrypoint_spec.rb | 5 +- 2 files changed, 5 insertions(+), 3 deletions(-) New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/ced25e450a822ad58de65a1026c85a2f73f5abf9 commit ced25e450a822ad58de65a1026c85a2f73f5abf9 Author: Dávid Halász <dhalasz> AuthorDate: Mon Jan 28 04:59:04 2019 -0500 Commit: Dávid Halász <dhalasz> CommitDate: Mon Jan 28 04:59:04 2019 -0500 Create a wrapper over favicon_link_tag for favicon customization https://bugzilla.redhat.com/show_bug.cgi?id=1578076 app/helpers/application_helper.rb | 4 + app/views/dashboard/oidc_login.html.haml | 2 +- app/views/dashboard/saml_login.html.haml | 2 +- app/views/layouts/application.html.haml | 2 +- app/views/layouts/login.html.haml | 2 +- app/views/layouts/print.html.haml | 2 +- app/views/layouts/remote_console.html.haml | 2 +- app/views/layouts/report_only.html.haml | 2 +- app/views/vm_common/console_vmrc.html.haml | 2 +- 9 files changed, 12 insertions(+), 8 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/556d907f8e859b132a2761f67aeab9f479bbb3c8 commit 556d907f8e859b132a2761f67aeab9f479bbb3c8 Author: Dávid Halász <dhalasz> AuthorDate: Mon Jan 28 05:26:43 2019 -0500 Commit: Dávid Halász <dhalasz> CommitDate: Mon Jan 28 05:26:43 2019 -0500 Allow the user to upload a custom favicon image in Custom Logos https://bugzilla.redhat.com/show_bug.cgi?id=1578076 app/controllers/ops_controller/settings/common.rb | 6 + app/controllers/ops_controller/settings/upload.rb | 20 +- app/views/ops/_settings_custom_logos_tab.html.haml | 28 + config/routes.rb | 1 + 4 files changed, 48 insertions(+), 7 deletions(-) FIXED. Verified on 5.11.0.4.20190514210444_0c91ee1. Canceling the needsinfo. I learned from BZ 1717695, Cloudforms 4.5 (CFME 5.8) has been closed for a long time. No backports. 5.9 is only getting critical CVE fixes and that window is closing fast. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |