Bug 1578076 - [RFE] Allow custom favicons and images into asset pipeline
Summary: [RFE] Allow custom favicons and images into asset pipeline
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.11.0
Assignee: Dávid Halász
QA Contact: Parthvi Vala
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-14 18:37 UTC by Robb Manes
Modified: 2022-03-13 14:59 UTC (History)
12 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:33:51 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:34:10 UTC

Description Robb Manes 2018-05-14 18:37:32 UTC
Description of problem:
As per later versions of CFME, as described in bz1553353, customizing the assets now is limited to a custom.css file which can apply any needed CSS to the CFME interface.  However, previously available customizations such as a favicon or replace images are no longer possible.

Prior to this, the following files were modifiable, which is what is specifically being requested now:

install -m 644 "${sourcedir}/brand.svg" productization/assets/images/layout/brand.svg
install -m 644 "${sourcedir}/favicon.ico" productization/assets/images/favicon.ico
install -m 644 "${sourcedir}/custom_logo.png" public/upload/custom_logo.png
install -m 644 "${sourcedir}/login-screen-background.png" public/upload/custom_login_logo.png

Would it be possible to include these as modifications to the UI, to brand CFME to match the organization it is being used with?

Version-Release number of selected component (if applicable):
Any 5.9 release.

Comment 15 CFME Bot 2019-02-13 05:52:20 UTC
New commit detected on ManageIQ/manageiq-api/master:

https://github.com/ManageIQ/manageiq-api/commit/2be8845460d72de55923bfd30c7dfcffafd8c8d3
commit 2be8845460d72de55923bfd30c7dfcffafd8c8d3
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Jan 29 16:08:57 2019 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue Jan 29 16:08:57 2019 -0500

    Expose the favicon URL in the branding info endpoints

    https://bugzilla.redhat.com/show_bug.cgi?id=1578076

 app/controllers/api/api_controller.rb | 3 +-
 spec/requests/entrypoint_spec.rb | 5 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

Comment 16 CFME Bot 2019-02-16 01:01:28 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/ced25e450a822ad58de65a1026c85a2f73f5abf9
commit ced25e450a822ad58de65a1026c85a2f73f5abf9
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jan 28 04:59:04 2019 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jan 28 04:59:04 2019 -0500

    Create a wrapper over favicon_link_tag for favicon customization

    https://bugzilla.redhat.com/show_bug.cgi?id=1578076

 app/helpers/application_helper.rb | 4 +
 app/views/dashboard/oidc_login.html.haml | 2 +-
 app/views/dashboard/saml_login.html.haml | 2 +-
 app/views/layouts/application.html.haml | 2 +-
 app/views/layouts/login.html.haml | 2 +-
 app/views/layouts/print.html.haml | 2 +-
 app/views/layouts/remote_console.html.haml | 2 +-
 app/views/layouts/report_only.html.haml | 2 +-
 app/views/vm_common/console_vmrc.html.haml | 2 +-
 9 files changed, 12 insertions(+), 8 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/556d907f8e859b132a2761f67aeab9f479bbb3c8
commit 556d907f8e859b132a2761f67aeab9f479bbb3c8
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jan 28 05:26:43 2019 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jan 28 05:26:43 2019 -0500

    Allow the user to upload a custom favicon image in Custom Logos

    https://bugzilla.redhat.com/show_bug.cgi?id=1578076

 app/controllers/ops_controller/settings/common.rb | 6 +
 app/controllers/ops_controller/settings/upload.rb | 20 +-
 app/views/ops/_settings_custom_logos_tab.html.haml | 28 +
 config/routes.rb | 1 +
 4 files changed, 48 insertions(+), 7 deletions(-)

Comment 17 Parthvi Vala 2019-05-16 10:53:08 UTC
FIXED. Verified on 5.11.0.4.20190514210444_0c91ee1.

Comment 19 Greg Scott 2019-07-03 17:50:32 UTC
Canceling the needsinfo. I learned from BZ 1717695, Cloudforms 4.5 (CFME 5.8) has been closed for a long time. No backports. 5.9 is only getting critical CVE fixes and that window is closing fast.

Comment 21 errata-xmlrpc 2019-12-12 13:33:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.