Bug 1578273

Summary: data-mismatch after split-brain + add-brick
Product: [Community] GlusterFS Reporter: Ravishankar N <ravishankar>
Component: replicateAssignee: Ravishankar N <ravishankar>
Status: CLOSED DEFERRED QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, pasik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-20 06:17:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ravishankar N 2018-05-15 07:25:39 UTC
Description of problem:
    When add-brick is performed on a replica 2 subvolume that has a file in
    data split-brain, the current logic for post-op failure accounting
    (originally added to fix spurious cyclic split-brains) picks up one of
    the 2 bricks as source, heals it into the newly added brick and resets the
    afr xattrs on  all 3 bricks. But the brick that was not chosen as source will
    still have different contents leading to silent data mismatch. The same
    problem is there even for metadata split-brain.

Comment 1 Ravishankar N 2018-05-15 07:31:31 UTC
https://review.gluster.org/#/c/20023/

Comment 2 Worker Ant 2018-05-15 07:31:32 UTC
REVIEW: https://review.gluster.org/20023 (afr: do not heal split-brain on add-brick) posted (#1) for review on master by Ravishankar N

Comment 3 Ravishankar N 2018-11-20 06:17:28 UTC
Closing the bug for now as the patch doesn't fully solve the problem and I'm not working on the complete fix at the moment.