Description of problem: When add-brick is performed on a replica 2 subvolume that has a file in data split-brain, the current logic for post-op failure accounting (originally added to fix spurious cyclic split-brains) picks up one of the 2 bricks as source, heals it into the newly added brick and resets the afr xattrs on all 3 bricks. But the brick that was not chosen as source will still have different contents leading to silent data mismatch. The same problem is there even for metadata split-brain.
https://review.gluster.org/#/c/20023/
REVIEW: https://review.gluster.org/20023 (afr: do not heal split-brain on add-brick) posted (#1) for review on master by Ravishankar N
Closing the bug for now as the patch doesn't fully solve the problem and I'm not working on the complete fix at the moment.