Bug 1578323

Summary: python-beaker FTFBS with Python 3.7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-beakerAssignee: Orphan Owner <extras-orphan>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kylev, rbarlow
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-23 13:54:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1565020    
Attachments:
Description Flags
Build log of python-beaker building against python 3.7 with async keyword patched out none

Description Miro Hrončok 2018-05-15 09:32:05 UTC 
Description of problem: python-beaker FTFBS with Python 3.7. 

According to https://www.python.org/dev/peps/pep-0492/ async and await are now keywords.

This leads to:

Bytecompiling .py files below /builddir/build/BUILDROOT/python-beaker-1.5.4-21.fc29.x86_64/usr/lib/python3.7 using /usr/bin/python3.7
*** Error compiling '/builddir/build/BUILDROOT/python-beaker-1.5.4-21.fc29.x86_64/usr/lib/python3.7/site-packages/beaker/synchronization.py'...
  File "/usr/lib/python3.7/synchronization.py", line 284
    self.async = 0
             ^
SyntaxError: invalid syntax

Version-Release number of selected component (if applicable): 1.5.4-21.fc29


How reproducible: hard / easy


Steps to Reproduce HARD:
1. rebuild everything needed for python-beaker with 3.7
2. rebuild python-beaker itself with 3.7

Actual results: SyntaxError: invalid syntax
Expected results: Should build

Steps to Reproduce EASY:
1. install python37
2. try to import beaker form sources, run tests, etc.

Additional info:
https://bugs.python.org/issue33514
Comment 1 Miro Hrončok 2018-05-15 09:33:28 UTC 
We need to either update to 1.9.1 or backport:

https://github.com/bbangert/beaker/commit/5f2e517e32e796ca391ddf312c04dd906bc5e376
Comment 2 Miro Hrončok 2018-05-15 09:45:07 UTC 
Created attachment 1436743 [details]
Build log of python-beaker building against python 3.7 with async keyword patched out

Even when I patch the self.async to self.asynch, the build fails on tests. Attaching buildlog.
Comment 3 Miro Hrončok 2018-05-17 14:07:59 UTC 
Upstream master works fine, so an update should solve this.  https://github.com/bbangert/beaker/pull/160
Comment 4 Miro Hrončok 2018-05-28 22:25:36 UTC 
Kyle?
Comment 5 Miro Hrončok 2018-05-30 10:48:50 UTC 
Ccing Randy, as this is indirect dependency of bodhi (trough mako).
Comment 6 Miro Hrončok 2018-06-05 18:02:31 UTC 
Bump.
Comment 7 Miro Hrončok 2018-06-08 10:37:44 UTC 
Kyle? 3.7.0c1 is expected in 3 days (2018-06-11, [1]). I'd like to start building stuff in a side tag soon after that.

If you don't respond I'm just gonna comment out the tests, as it seems like that's fine for mako.

[1] https://www.python.org/dev/peps/pep-0537/
Comment 8 Miro Hrončok 2018-06-08 13:08:54 UTC 
We can get rid of beaker from mako:

https://src.fedoraproject.org/rpms/python-mako/pull-request/3

I'll merge this if nobody fixes beaker.
Comment 9 Miro Hrončok 2018-07-23 13:54:33 UTC 

*** This bug has been marked as a duplicate of bug 1605613 ***
Comment 10 Red Hat Bugzilla 2023-09-14 04:28:07 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days