Bug 1578381

Summary:	Error message need update when specify numa distance with node index >=128
Product:	Red Hat Enterprise Linux 7	Reporter:	Yumei Huang <yuhuang>
Component:	qemu-kvm-rhev	Assignee:	Igor Mammedov <imammedo>
Status:	CLOSED ERRATA	QA Contact:	Yumei Huang <yuhuang>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.6	CC:	chayang, drjones, imammedo, jinzhao, juzhang, knoel, michen, virt-maint
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-kvm-rhev-2.12.0-7.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-01 11:09:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yumei Huang 2018-05-15 12:44:58 UTC

Description of problem:
Boot guest with CLI "-numa dist,src=128,dst=1,val=20", the error message is:

qemu-kvm: -numa dist,src=128,dst=1,val=20: Invalid node 128, max possible could be 128

Which is kind of contradict.

The max index should be 127. The error message need update.


Version-Release number of selected component (if applicable):
qemu-kvm-rhev-2.12.0-1.el7
kernel-3.10.0-862.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1. Boot guest
# /usr/libexec/qemu-kvm -m 24G -smp 16 rhel76-64-virtio-scsi.qcow2 \
-netdev tap,id=tap0 -device virtio-net-pci,id=net0,netdev=tap0 \
-vnc :1 -monitor stdio \
-numa node,nodeid=0 \
-numa node,nodeid=1 \
-numa dist,src=128,dst=1,val=20
2.
3.

Actual results:
QEMU quits with error message:
(qemu) qemu-kvm: -numa dist,src=128,dst=1,val=20: Invalid node 128, max possible could be 128


Expected results:
Error message shows the correct max value or the range.

Additional info:

Comment 2 Igor Mammedov 2018-07-02 13:59:05 UTC

Posted:
"[RHEL-7.6 qemu-kvm-rhev PATCH] numa: clarify error message when node index is out of range in -numa dist, ..."

Comment 4 Miroslav Rezanina 2018-07-04 08:31:03 UTC

Fix included in qemu-kvm-rhev-2.12.0-7.el7

Comment 6 Yumei Huang 2018-07-05 05:05:32 UTC

Verify:
qemu-kvm-rhev-2.12.0-7.el7

# /usr/libexec/qemu-kvm -numa node,nodeid=0 -numa node,nodeid=1 -numa dist,src=128,dst=1,val=20
qemu-kvm: -numa dist,src=128,dst=1,val=20: Parameter 'src' expects an integer between 0 and 127


# /usr/libexec/qemu-kvm -numa node,nodeid=0 -numa node,nodeid=1 -numa dist,src=1,dst=128,val=20
qemu-kvm: -numa dist,src=1,dst=128,val=20: Parameter 'dst' expects an integer between 0 and 127

Comment 7 errata-xmlrpc 2018-11-01 11:09:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3443