Bug 1580212

Summary:	Two different environment variables used to control NPD installation (during cluster deployment and with ansible playbook)
Product:	OpenShift Container Platform	Reporter:	Weinan Liu <weinliu>
Component:	Installer	Assignee:	Joel Smith <joelsmith>
Status:	CLOSED NOTABUG	QA Contact:	Weinan Liu <weinliu>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.10.0	CC:	aos-bugs, jchaloup, joelsmith, jokerman, mmccomas
Target Milestone:	---
Target Release:	3.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1569826	Environment:
Last Closed:	2019-01-28 18:30:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Weinan Liu 2018-05-21 03:25:51 UTC

Description of problem:
Two different environment variables used to control if NPD install :
Using ansible playbook: openshift_node_problem_detector_state=present
During cluster deployment (on Jenkins): openshift_node_problem_detector_install: true
It would be confusing for the users.

Version-Release number of selected component (if applicable):
[root@qe-weinliu310-2master-etcd-1 ~]# oc version
oc v3.10.0-0.30.0
kubernetes v1.10.0+b81c8f8
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://qe-weinliu310-2master-etcd-1:8443
openshift v3.10.0-0.30.0
kubernetes v1.10.0+b81c8f8
[root@qe-weinliu310-2master-etcd-1 ~]# uname -a
Linux qe-weinliu310-2master-etcd-1 3.10.0-862.el7.x86_64 #1 SMP Wed Mar 21 18:14:51 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux
[root@qe-weinliu310-2master-etcd-1 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.5 (Maipo)

How reproducible:
always

Steps to Reproduce:
1. As description

Actual results:
Two different environment variables used

Expected results:
Unique environment variable used to control both of the two install methods, to avoid confusing.

Additional info:
N/A

Comment 1 Scott Dodson 2018-05-31 14:15:29 UTC

https://trello.com/c/OA9z4cMU/701-8-node-deliver-node-problem-detector-for-tech-preview says NPD is tech-preview therefore not a 3.10 blocker here.

Comment 2 Weinan Liu 2018-07-23 06:21:43 UTC

(In reply to Scott Dodson from comment #1)
> https://trello.com/c/OA9z4cMU/701-8-node-deliver-node-problem-detector-for-
> tech-preview says NPD is tech-preview therefore not a 3.10 blocker here.

any plans for getting this updated?

Comment 3 Scott Dodson 2019-01-28 18:30:30 UTC

openshift_node_problem_detector_install = true should be the only variable that's required. Internal to the role openshift_node_problem_detector_install is used to force removal of the npd and should not need to be set to install.