Bug 1582095
| Summary: | [patch] add package for fdt static library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bas Mevissen <redhat.bugzilla> | ||||||
| Component: | dtc | Assignee: | Peter Robinson <pbrobinson> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 28 | CC: | arnd, jwboyer, pbonzini, pbrobinson | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-06-08 02:12:40 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Patch looks good to me. The only thing I would change is referencing this bug in the changelog. Thanks for the review. As I added the patch while creating the bug report, I had a chicken and egg problem with referencing to the bug ;-) Created attachment 1448295 [details]
Updates patch including bugzilla number in changelog
Refreshed patch to include bugzilla number in changelog
Pushed to rawhide, thanks Can this also be pushed to F28 please? |
Created attachment 1440975 [details] Patch to add libfdt-static package The current DTC source package only provides the dynamic library of libfdt. The attached patch adds a package that provides libfdt.a as well. Rational is that some tools require linking to the static library to keep the number of dependencies down. The current build of the DTC package does already create libfdt.a. However, it is deleted just before packaging. The attached patch removes that deletion and adds a definition for the libfdt-static package. Please consider for inclusion.