Bug 1582095 - [patch] add package for fdt static library
Summary: [patch] add package for fdt static library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dtc
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-24 08:26 UTC by Bas Mevissen
Modified: 2018-06-11 08:03 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-08 02:12:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to add libfdt-static package (1.49 KB, patch)
2018-05-24 08:26 UTC, Bas Mevissen
no flags Details | Diff
Updates patch including bugzilla number in changelog (1.50 KB, patch)
2018-06-06 11:44 UTC, Bas Mevissen
no flags Details | Diff

Description Bas Mevissen 2018-05-24 08:26:49 UTC
Created attachment 1440975 [details]
Patch to add libfdt-static package

The current DTC source package only provides the dynamic library of libfdt. The attached patch adds a package that provides libfdt.a as well.

Rational is that some tools require linking to the static library to keep the number of dependencies down.

The current build of the DTC package does already create libfdt.a. However, it is deleted just before packaging. The attached patch removes that deletion and adds a definition for the libfdt-static package.

Please consider for inclusion.

Comment 1 Josh Boyer 2018-05-24 11:49:04 UTC
Patch looks good to me.  The only thing I would change is referencing this bug in the changelog.

Comment 2 Bas Mevissen 2018-05-24 11:51:43 UTC
Thanks for the review. As I added the patch while creating the bug report, I had a chicken and egg problem with referencing to the bug ;-)

Comment 3 Bas Mevissen 2018-06-06 11:44:05 UTC
Created attachment 1448295 [details]
Updates patch including bugzilla number in changelog

Refreshed patch to include bugzilla number in changelog

Comment 4 Peter Robinson 2018-06-08 02:12:40 UTC
Pushed to rawhide, thanks

Comment 6 Bas Mevissen 2018-06-11 08:03:40 UTC
Can this also be pushed to F28 please?


Note You need to log in before you can comment on or make changes to this bug.