Bug 1582272

Description of problem:
When 'merge overrides' is not selected then this works. When I switch on the 'merge overrides' option, then this fails with the below mentioned back traces. As mentioned in the below notes it looks like when erb is inserted then this is added as a string into the matcher (as evidenced by the API call):


Version-Release number of selected component (if applicable):
Satellite 6.3

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
https://testsatellite.example.com/api/v2/smart_class_parameters/349/override_values) this means the deep_merge is going to fail to merge:

{
    "total": 1,
    "subtotal": 1,
    "page": 1,
    "per_page": 30,
    "search": null,
    "sort": {
        "by": null,
        "order": null
    },
    "results": [
        {
            "created_at": "2018-05-10 20:16:53 UTC",
            "updated_at": "2018-05-10 20:18:39 UTC",
            "id": 6923,
            "match": "fqdn=testclient.example.com",
            "value": "test:\r\n  value: <%= @host.facts['memorysize_mb'] %>\r\n",
            "omit": false,
            "use_puppet_default": false
        }
    ]
}

With no erb this is stored in its correct type (hash):

https://testsatellite.example.com/api/v2/smart_class_parameters/349/override_values

{
    "total": 1,
    "subtotal": 1,
    "page": 1,
    "per_page": 30,
    "search": null,
    "sort": {
        "by": null,
        "order": null
    },
    "results": [
        {
            "created_at": "2018-05-10 20:16:53 UTC",
            "updated_at": "2018-05-10 20:16:53 UTC",
            "id": 6923,
            "match": "fqdn=testclient.example.com",
            "value": {
                "test": {
                    "value": 24
                }
            },
            "omit": false,
            "use_puppet_default": false
        }
    ]
}
Expected results:
 with erb enabled, facts would be stored as a hash and not a string

Additional info:
http://projects.theforeman.org/issues/9949