Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1582272 - deep merge broken when using facts in hash
Summary: deep merge broken when using facts in hash
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Puppet
Version: 6.3.1
Hardware: x86_64
OS: Linux
high
high
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Peter Ondrejka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-24 16:58 UTC by Taft Sanders
Modified: 2023-03-24 14:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-15 20:30:53 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 9949 0 Normal New deep merge broken when using facts in hash 2020-05-26 06:38:14 UTC

Description Taft Sanders 2018-05-24 16:58:01 UTC
Description of problem:
When 'merge overrides' is not selected then this works. When I switch on the 'merge overrides' option, then this fails with the below mentioned back traces. As mentioned in the below notes it looks like when erb is inserted then this is added as a string into the matcher (as evidenced by the API call):


Version-Release number of selected component (if applicable):
Satellite 6.3

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
https://testsatellite.example.com/api/v2/smart_class_parameters/349/override_values) this means the deep_merge is going to fail to merge:

{
    "total": 1,
    "subtotal": 1,
    "page": 1,
    "per_page": 30,
    "search": null,
    "sort": {
        "by": null,
        "order": null
    },
    "results": [
        {
            "created_at": "2018-05-10 20:16:53 UTC",
            "updated_at": "2018-05-10 20:18:39 UTC",
            "id": 6923,
            "match": "fqdn=testclient.example.com",
            "value": "test:\r\n  value: <%= @host.facts['memorysize_mb'] %>\r\n",
            "omit": false,
            "use_puppet_default": false
        }
    ]
}

With no erb this is stored in its correct type (hash):

https://testsatellite.example.com/api/v2/smart_class_parameters/349/override_values

{
    "total": 1,
    "subtotal": 1,
    "page": 1,
    "per_page": 30,
    "search": null,
    "sort": {
        "by": null,
        "order": null
    },
    "results": [
        {
            "created_at": "2018-05-10 20:16:53 UTC",
            "updated_at": "2018-05-10 20:16:53 UTC",
            "id": 6923,
            "match": "fqdn=testclient.example.com",
            "value": {
                "test": {
                    "value": 24
                }
            },
            "omit": false,
            "use_puppet_default": false
        }
    ]
}
Expected results:
 with erb enabled, facts would be stored as a hash and not a string

Additional info:
http://projects.theforeman.org/issues/9949

Comment 2 Ondřej Pražák 2019-01-16 08:58:52 UTC
Connecting redmine issue http://projects.theforeman.org/issues/9949 from this bug

Comment 3 Bryan Kearney 2019-12-03 16:35:02 UTC
The Satellite Team is attempting to provide an accurate backlog of bugzilla requests which we feel will be resolved in the next few releases. We do not believe this bugzilla will meet that criteria, and have plans to close it out in 1 month. This is not a reflection on the validity of the request, but a reflection of the many priorities for the product. If you have any concerns about this, feel free to contact Red Hat Technical Support or your account team. If we do not hear from you, we will close this bug out. Thank you.

Comment 4 Bryan Kearney 2020-01-15 20:30:53 UTC
Thank you for your interest in Satellite 6. We have evaluated this request, and while we recognize that it is a valid request, we do not expect this to be implemented in the product in the foreseeable future. This is due to other priorities for the product, and not a reflection on the request itself. We are therefore closing this out as WONTFIX. If you have any concerns about this, please do not reopen. Instead, feel free to contact Red Hat Technical Support. Thank you.


Note You need to log in before you can comment on or make changes to this bug.