Bug 1584700

Summary: Review Request: nodejs-rollup-plugin-node-resolve - Bundle third-party dependencies in node_modules
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-31 16:39:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1584365    
Bug Blocks: 956806, 1572709, 1584795, 1584840, 1584891    

Comment 1 Robert-André Mauchin 🐧 2018-05-31 14:47:36 UTC
Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.F9hjWu
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'builtin-modules'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.k5x3e5
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'resolve'
Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.1TwU1I
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'is-module'


   Add the missing BR:

BuildRequires:	npm(builtin-modules)
BuildRequires:	npm(resolve)
BuildRequires:	npm(is-module)




 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 2 Jared Smith 2018-05-31 15:15:47 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6843.

Comment 3 Gwyn Ciesla 2018-05-31 15:19:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-rollup-plugin-node-resolve

Comment 4 Jared Smith 2018-05-31 16:39:18 UTC
Packaged in Rawhide, closing this issue