Bug 1584700 - Review Request: nodejs-rollup-plugin-node-resolve - Bundle third-party dependencies in node_modules
Summary: Review Request: nodejs-rollup-plugin-node-resolve - Bundle third-party depend...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1584365
Blocks: nodejs-reviews mozgw 1584795 1584840 1584891
TreeView+ depends on / blocked
 
Reported: 2018-05-31 13:13 UTC by Jared Smith
Modified: 2018-05-31 21:15 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-05-31 16:39:18 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2018-05-31 14:47:36 UTC
Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.F9hjWu
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'builtin-modules'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.k5x3e5
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'resolve'
Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.1TwU1I
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'is-module'


   Add the missing BR:

BuildRequires:	npm(builtin-modules)
BuildRequires:	npm(resolve)
BuildRequires:	npm(is-module)




 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 2 Jared Smith 2018-05-31 15:15:47 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6843.

Comment 3 Gwyn Ciesla 2018-05-31 15:19:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-rollup-plugin-node-resolve

Comment 4 Jared Smith 2018-05-31 16:39:18 UTC
Packaged in Rawhide, closing this issue


Note You need to log in before you can comment on or make changes to this bug.