Bug 1584973
| Summary: | Review Request: golang-github-git-lfs-netrc - A Golang package for reading and writing netrc files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carlwgeorge, eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-09-06 02:32:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1563188 | ||
| Bug Blocks: | 1583642 | ||
|
Description
Elliott Sales de Andrade
2018-06-01 05:08:13 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27338818 Could you use the new Golang packaging guidelines? https://fedoraproject.org/wiki/More_Go_packaging See examples here: https://eclipseo.fedorapeople.org/golang/ Update gofed with updates-testing to get the new one which generates SPEC according to the new guidelines: sudo dnf update gofed --enablerepo=updates-testing The %{goname} removes go- and git- from the name; I understand the former, but why the latter? Is that really a big problem with Go packages?
I don't know actually, you should ask nim or jchaloup at https://github.com/gofed/go-macros/issues I added a little hack to make it produce the correct name: Spec URL: https://qulogic.fedorapeople.org/golang-github-git-lfs-netrc.spec SRPM URL: https://qulogic.fedorapeople.org/golang-github-git-lfs-netrc-0-0.1.20180601gite0e9ca4.fc28.src.rpm - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-git-lfs-netrc golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8816410875 golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1916746967 golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8816410875 golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1916746967 golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |