Bug 1586076
| Summary: | API server crashes when using old format of webhook triggers in build Configs | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Ben Parees <bparees> |
| Component: | Build | Assignee: | Ben Parees <bparees> |
| Status: | CLOSED ERRATA | QA Contact: | Wenjing Zheng <wzheng> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 3.9.0 | CC: | ansverma, aos-bugs, bparees, jkaur, jmalde, jokerman, mfojtik, mmccomas, wzheng |
| Target Milestone: | --- | ||
| Target Release: | 3.9.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: The webhook payload can contain an empty commit array which results in an array indexing error when processed by the api server.
Consequence: The api server crashes.
Fix: Check for an empty array before attempting to index into it.
Result: Empty commit payloads are handled w/o crashing the api server.
|
Story Points: | --- |
| Clone Of: | 1585663 | Environment: | |
| Last Closed: | 2018-06-27 18:02:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1585663 | ||
| Bug Blocks: | |||
|
Comment 1
Ben Parees
2018-06-05 12:57:19 UTC
Verified with below version:
openshift v3.9.31
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.16
{
"kind": "Status",
"apiVersion": "v1",
"metadata": {},
"status": "Failure",
"message": "Unable to extract valid event from payload:
<-------------->
"reason": "BadRequest",
"code": 400
}
And master api not restart.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2013 |