Bug 1586076 – API server crashes when using old format of webhook triggers in build Configs

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1586076 - API server crashes when using old format of webhook triggers in build Configs

Summary:	API server crashes when using old format of webhook triggers in build Configs

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Build (Show other bugs)
Sub Component:
Version:	3.9.0
Hardware:	Unspecified Unspecified

Priority	urgent Severity urgent
Target Milestone:	---
Target Release:	3.9.z
Assigned To:	Ben Parees
QA Contact:	Wenjing Zheng
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:	1585663
Blocks:
	Show dependency tree / graph

Reported:	2018-06-05 08:53 EDT by Ben Parees
Modified:	2018-06-27 14:02 EDT (History)
CC List:	9 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Cause: The webhook payload can contain an empty commit array which results in an array indexing error when processed by the api server. Consequence: The api server crashes. Fix: Check for an empty array before attempting to index into it. Result: Empty commit payloads are handled w/o crashing the api server.
Story Points:	---
Clone Of:	1585663
Environment:
Last Closed:	2018-06-27 14:02:09 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2018:2013	normal	SHIPPED_LIVE	Important: OpenShift Container Platform 3.9 security, bug fix, and enhancement update	2018-06-27 18:01:43 EDT

Groups: None (edit)

Comment 1 Ben Parees 2018-06-05 08:57:19 EDT

https://github.com/openshift/ose/pull/1303

Comment 3 Wenjing Zheng 2018-06-12 23:18:33 EDT

Verified with below version:
openshift v3.9.31
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.16

{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "Unable to extract valid event from payload: 
   <-------------->
   "reason": "BadRequest",
  "code": 400
}

And master api not restart.

Comment 5 errata-xmlrpc 2018-06-27 14:02:09 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2013

Note You need to log in before you can comment on or make changes to this bug.