Bug 1586363

Summary:	Refactor rebalance code
Product:	[Community] GlusterFS	Reporter:	Nithya Balachandran <nbalacha>
Component:	distribute	Assignee:	bugs <bugs>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs, spalai
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-18 08:33:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nithya Balachandran 2018-06-06 05:38:30 UTC

Description of problem:

Rebalance code has:

* Several large functions which can be broken up for better readability
* Code scattered in various functions making error handling difficult.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-06-06 07:34:01 UTC

REVIEW: https://review.gluster.org/20169 (cluster/dht: Refactor rebalance code) posted (#1) for review on master by N Balachandran

Comment 2 Worker Ant 2018-06-13 03:49:30 UTC

COMMIT: https://review.gluster.org/20169 committed in master by "N Balachandran" <nbalacha> with a commit message- cluster/dht: Refactor rebalance code

Created init and cleanup functions for certain
functionality in order to improve readability.
Removed unused code.

Change-Id: Ia6a2f4ab64923b6ea8e10487227fb5621eec1488
updates: bz#1586363
Signed-off-by: N Balachandran <nbalacha>

Comment 3 Nithya Balachandran 2018-06-13 04:12:22 UTC

(In reply to Worker Ant from comment #2)
> COMMIT: https://review.gluster.org/20169 committed in master by "N
> Balachandran" <nbalacha> with a commit message- cluster/dht:
> Refactor rebalance code
> 
> Created init and cleanup functions for certain
> functionality in order to improve readability.
> Removed unused code.
> 
> Change-Id: Ia6a2f4ab64923b6ea8e10487227fb5621eec1488
> updates: bz#1586363
> Signed-off-by: N Balachandran <nbalacha>


This is the first patch that refactors the code. These changes only create init and cleanup functions for some of the operations performed during startup.


There will be more patches so this BZ must stay open.

Comment 4 Shyamsundar 2018-10-23 15:11:13 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Nithya Balachandran 2018-10-29 02:59:12 UTC

Reopening as there are more code changes expected for this.

Comment 7 Susant Kumar Palai 2020-02-18 08:33:53 UTC

Not a priority right now, please reopen when this is being worked on.