Description of problem: Rebalance code has: * Several large functions which can be broken up for better readability * Code scattered in various functions making error handling difficult. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: https://review.gluster.org/20169 (cluster/dht: Refactor rebalance code) posted (#1) for review on master by N Balachandran
COMMIT: https://review.gluster.org/20169 committed in master by "N Balachandran" <nbalacha> with a commit message- cluster/dht: Refactor rebalance code Created init and cleanup functions for certain functionality in order to improve readability. Removed unused code. Change-Id: Ia6a2f4ab64923b6ea8e10487227fb5621eec1488 updates: bz#1586363 Signed-off-by: N Balachandran <nbalacha>
(In reply to Worker Ant from comment #2) > COMMIT: https://review.gluster.org/20169 committed in master by "N > Balachandran" <nbalacha> with a commit message- cluster/dht: > Refactor rebalance code > > Created init and cleanup functions for certain > functionality in order to improve readability. > Removed unused code. > > Change-Id: Ia6a2f4ab64923b6ea8e10487227fb5621eec1488 > updates: bz#1586363 > Signed-off-by: N Balachandran <nbalacha> This is the first patch that refactors the code. These changes only create init and cleanup functions for some of the operations performed during startup. There will be more patches so this BZ must stay open.
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report. glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html [2] https://www.gluster.org/pipermail/gluster-users/
Reopening as there are more code changes expected for this.
Not a priority right now, please reopen when this is being worked on.