Bug 1590952

Summary:	CinderNetappNfsMountOptions missing from puppet manifest
Product:	Red Hat OpenStack	Reporter:	Alan Bishop <abishop>
Component:	puppet-tripleo	Assignee:	Alan Bishop <abishop>
Status:	CLOSED ERRATA	QA Contact:	Tzach Shefi <tshefi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	13.0 (Queens)	CC:	aavraham, abishop, cpaquin, jjoyce, joflynn, jschluet, knylande, pmannidi, regis.jarde, slinaber, srevivo, tshefi, tvignaud
Target Milestone:	z2	Keywords:	Rebase, Reopened, Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	puppet-tripleo-8.3.4-2.el7ost	Doc Type:	Bug Fix
Doc Text:	The Cinder Netapp backend ignored the CinderNetappNfsMountOptions TripleO Heat parameter that prevented configuration of the Netapp NFS mount options via the TripleO Heat parameter. The code responsible for handling Cinder's Netapp configuration does not ignore the CinderNetappNfsMountOptions parameter. The CinderNetappNfsMountOptions parameter correctly configures Cinder's Netapp NFS mount options.	Story Points:	---
Clone Of:	1567368
Clones:	1590953 (view as bug list)		Environment:
Last Closed:	2019-01-02 18:08:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alan Bishop 2018-06-13 17:59:47 UTC

+++ This bug was initially created as a clone of Bug #1567368 +++

Description of problem:

cinder-netapp.yaml has a parameter for nfs mount options

CinderNetappNfsMountOptions 

This param is referenced in /usr/share/openstack-tripleo-heat-templates/puppet/extraconfig/pre_deploy/controller/cinder-netapp.yaml

The specific line is below. 

cinder::backend::netapp::nfs_mount_options: {get_input: NetappNfsMountOptions}

However, the puppet template , /etc/puppet/modules/tripleo/manifests/profile/base/cinder/volume/netapp.pp
does not include NFS mount options, inline with the other values such as  what is shown below.

cinder::backend::netapp { $backend_name :
      netapp_login                 => hiera('cinder::backend::netapp::netapp_login', undef),
      netapp_password              => hiera('cinder::backend::netapp::netapp_password', undef),
      netapp_server_hostname       => hiera('cinder::backend::netapp::netapp_server_hostname', undef),
      netapp_server_port           => hiera('cinder::backend::netapp::netapp_server_port', undef),
      netapp_size_multiplier       => hiera('cinder::backend::netapp::netapp_size_multiplier', undef),
      netapp_storage_family        => hiera('cinder::backend::netapp::netapp_storage_family', undef),
      netapp_storage_protocol      => hiera('cinder::backend::netapp::netapp_storage_protocol', undef),
      netapp_transport_type        => hiera('cinder::backend::netapp::netapp_transport_type', undef),
      netapp_vfiler                => hiera('cinder::backend::netapp::netapp_vfiler', undef),
      netapp_volume_list           => hiera('cinder::backend::netapp::netapp_volume_list', undef),
      netapp_vserver               => hiera('cinder::backend::netapp::netapp_vserver', undef),
      netapp_partner_backend_name  => hiera('cinder::backend::netapp::netapp_partner_backend_name', undef),
      nfs_shares                   => $cinder_netapp_nfs_shares,
      nfs_shares_config            => hiera('cinder::backend::netapp::nfs_shares_config', undef),
      netapp_copyoffload_tool_path => hiera('cinder::backend::netapp::netapp_copyoffload_tool_path', undef),
      netapp_controller_ips        => hiera('cinder::backend::netapp::netapp_controller_ips', undef),
      netapp_sa_password           => hiera('cinder::backend::netapp::netapp_sa_password', undef),
      netapp_storage_pools         => hiera('cinder::backend::netapp::netapp_storage_pools', undef),
      netapp_eseries_host_type     => hiera('cinder::backend::netapp::netapp_eseries_host_type', undef),
      netapp_webservice_path       => hiera('cinder::backend::netapp::netapp_webservice_path', undef),
    }
  }



How reproducible:
Deploy cinder netapp backend, attempt to set nfs mount options using override in a template, deploy completes however, no value for CinderNetappNfsMountOptions is not set.

Comment 1 Alan Bishop 2018-06-13 18:11:56 UTC

Patch will land in OSP-13 when upstream is imported for 13z1.

Comment 13 errata-xmlrpc 2018-08-29 16:37:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2574

Comment 14 RegisJ 2018-12-23 22:30:27 UTC

Hello we have setup a new fresh openstack 13 version with a netapp backend. We have had this option :
CinderNetappNfsMountOptions: 'nfsvers=3' to enforce usage of NFS V3 and it seem's that's not work because on the first instance we have created on our Netapp file server the compute node do a mount using nfs V4.1 protocole ...
Are you sure the originl bug is solved ?

Where can we check on the compute node the netapp setup configuration and nfs option used to perfom the mount ?

Regards

Comment 15 RegisJ 2018-12-23 22:56:42 UTC

I have finally found configuration file in controler node.
Here:
/var/lib/config-data/cinder/etc/cinder/cinder.conf
it contain the row :
nfs_mount_options=nfsvers=3
but it seem's to be ignored because the mount is done using nfs V4.1 on the compute node :
10.14.36.119:/OpenStack13_2 on /var/lib/nova/mnt/21d5979383c4ca6dd672cdde379711b3 type nfs4 (rw,relatime,vers=4.1,rsize=65536 ....

Comment 16 Alan Bishop 2019-01-02 18:08:12 UTC

@RegisJ,

I realize your issue is related to NFS mount options, but this bug fixes a specific issue related to the CinderNetappNfsMountOptions heat parameter.

Please file a new bug for the issue you're seeing. We'll need to see cinder and nova logs, preferably at DEBUG level.