Bug 1591116

Summary: Review Request: perl-Hash-AutoHash-Args - Object-oriented processing of keyword-based argument lists
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Hash-AutoHash-Args-1.18-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-14 14:18:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1591111    
Bug Blocks: 1098012    

Description Petr Pisar 2018-06-14 06:07:03 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Hash-AutoHash-Args/perl-Hash-AutoHash-Args.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Hash-AutoHash-Args/perl-Hash-AutoHash-Args-1.18-1.fc29.src.rpm
Description:
This Perl class simplifies the handling of keyword argument lists. It replaces
Class::AutoClass::Args.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2018-06-14 12:52:06 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Hash-AutoHash-Args-1.18-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp) >= 1.2
      1 perl(Hash::AutoHash) >= 1.17
      1 perl(Hash::AutoHash::Args)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Tie::Hash) >= 1.04
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Hash-AutoHash-Args-1.18-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Hash::AutoHash::Args) = 1.18
      1 perl-Hash-AutoHash-Args = 1.18-1.fc29
      1 perl(Hash::AutoHash::Args::helper)
      1 perl(Hash::AutoHash::Args::tie)
      1 perl(Hash::AutoHash::Args::V0) = 1.18
      1 perl(Hash::AutoHash::Args::V0::helper)
Binary provides are Ok.

$ rpmlint ./perl-Hash-AutoHash-Args*
perl-Hash-AutoHash-Args.noarch: W: spelling-error %description -l en_US AutoClass -> Auto Class, Auto-class, Autoclaves
perl-Hash-AutoHash-Args.src: W: spelling-error %description -l en_US AutoClass -> Auto Class, Auto-class, Autoclaves
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved
Comment 2 Gwyn Ciesla 2018-06-14 13:14:41 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Hash-AutoHash-Args
Comment 3 Petr Pisar 2018-06-14 14:18:43 UTC 
Thank you for the review and the repository.