Bug 1591116 - Review Request: perl-Hash-AutoHash-Args - Object-oriented processing of keyword-based argument lists
Summary: Review Request: perl-Hash-AutoHash-Args - Object-oriented processing of keywo...
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On: 1591111
Blocks: 1098012
TreeView+ depends on / blocked
 
Reported: 2018-06-14 06:07 UTC by Petr Pisar
Modified: 2018-06-14 14:18 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2018-06-14 14:18:43 UTC
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2018-06-14 06:07:03 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Hash-AutoHash-Args/perl-Hash-AutoHash-Args.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Hash-AutoHash-Args/perl-Hash-AutoHash-Args-1.18-1.fc29.src.rpm
Description:
This Perl class simplifies the handling of keyword argument lists. It replaces
Class::AutoClass::Args.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-06-14 12:52:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Hash-AutoHash-Args-1.18-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp) >= 1.2
      1 perl(Hash::AutoHash) >= 1.17
      1 perl(Hash::AutoHash::Args)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Tie::Hash) >= 1.04
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Hash-AutoHash-Args-1.18-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Hash::AutoHash::Args) = 1.18
      1 perl-Hash-AutoHash-Args = 1.18-1.fc29
      1 perl(Hash::AutoHash::Args::helper)
      1 perl(Hash::AutoHash::Args::tie)
      1 perl(Hash::AutoHash::Args::V0) = 1.18
      1 perl(Hash::AutoHash::Args::V0::helper)
Binary provides are Ok.

$ rpmlint ./perl-Hash-AutoHash-Args*
perl-Hash-AutoHash-Args.noarch: W: spelling-error %description -l en_US AutoClass -> Auto Class, Auto-class, Autoclaves
perl-Hash-AutoHash-Args.src: W: spelling-error %description -l en_US AutoClass -> Auto Class, Auto-class, Autoclaves
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2018-06-14 13:14:41 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Hash-AutoHash-Args

Comment 3 Petr Pisar 2018-06-14 14:18:43 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.