Bug 159140

Summary: gdm-early-login fails if firstboot rpm isn't installed
Product: [Fedora] Fedora Reporter: Valdis Kletnieks <valdis.kletnieks>
Component: gdmAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED WONTFIX QA Contact: Mike McLean <mikem>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: sergio.pasra
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-06 19:27:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 158504    
Attachments:
Description Flags
works-for-me patch against gdm startup scripts
none
Updated patch...
none
Argh. Try again... none

Description Valdis Kletnieks 2005-05-30 15:54:38 UTC 
Description of problem:
A bad test for /etc/sysconfig/firstboot causes gdm-early-login to exit
incorrectly.  If the file doesn't exist, it falls out of the end of the
do_firstboot function with a default 'return 0' instead of doing a return 1.

Version-Release number of selected component (if applicable):
gdm-2.6.0.8-16

How reproducible:
Remove the firstboot rpm and reboot with gdm-early-login configured

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Patch against /etc/init.d scripts attached.
Comment 1 Valdis Kletnieks 2005-05-30 15:54:38 UTC 
Created attachment 114974 [details]
works-for-me patch against gdm startup scripts
Comment 2 Valdis Kletnieks 2005-06-01 16:43:28 UTC 
Created attachment 115040 [details]
Updated patch...

Damn. I missed the zzz-bootup-complete script, which needs the same fix as the
other two.
Comment 3 Valdis Kletnieks 2005-06-01 17:01:47 UTC 
Created attachment 115042 [details]
Argh. Try again...

It's definitely a Murphy day. Missed a '!' in there - not sure why I didn't see
a problme when I tested it.
Comment 4 Ray Strode [halfline] 2007-03-06 19:27:26 UTC 
we aren't supporting early boot anymore, so i'm going to close this out. Thanks
for the patch, though.