Bug 159140 - gdm-early-login fails if firstboot rpm isn't installed
Summary: gdm-early-login fails if firstboot rpm isn't installed
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: gdm
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact: Mike McLean
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FC4Update
TreeView+ depends on / blocked
 
Reported: 2005-05-30 15:54 UTC by Valdis Kletnieks
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-03-06 19:27:26 UTC


Attachments (Terms of Use)
works-for-me patch against gdm startup scripts (973 bytes, patch)
2005-05-30 15:54 UTC, Valdis Kletnieks
no flags Details | Diff
Updated patch... (1.42 KB, patch)
2005-06-01 16:43 UTC, Valdis Kletnieks
no flags Details | Diff
Argh. Try again... (1.42 KB, patch)
2005-06-01 17:01 UTC, Valdis Kletnieks
no flags Details | Diff

Description Valdis Kletnieks 2005-05-30 15:54:38 UTC
Description of problem:
A bad test for /etc/sysconfig/firstboot causes gdm-early-login to exit
incorrectly.  If the file doesn't exist, it falls out of the end of the
do_firstboot function with a default 'return 0' instead of doing a return 1.

Version-Release number of selected component (if applicable):
gdm-2.6.0.8-16

How reproducible:
Remove the firstboot rpm and reboot with gdm-early-login configured

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Patch against /etc/init.d scripts attached.

Comment 1 Valdis Kletnieks 2005-05-30 15:54:38 UTC
Created attachment 114974 [details]
works-for-me patch against gdm startup scripts

Comment 2 Valdis Kletnieks 2005-06-01 16:43:28 UTC
Created attachment 115040 [details]
Updated patch...

Damn. I missed the zzz-bootup-complete script, which needs the same fix as the
other two.

Comment 3 Valdis Kletnieks 2005-06-01 17:01:47 UTC
Created attachment 115042 [details]
Argh. Try again...

It's definitely a Murphy day. Missed a '!' in there - not sure why I didn't see
a problme when I tested it.

Comment 4 Ray Strode [halfline] 2007-03-06 19:27:26 UTC
we aren't supporting early boot anymore, so i'm going to close this out. Thanks
for the patch, though.


Note You need to log in before you can comment on or make changes to this bug.