Bug 1592564
| Summary: | Please update vxl to post 2012 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark Harfouche <mark.harfouche> | ||||||||||
| Component: | vxl | Assignee: | Igor Raits <igor.raits> | ||||||||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||
| Priority: | unspecified | ||||||||||||
| Version: | 28 | CC: | igor.raits, mrceresa, orion, sanjay.ankur | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2018-11-15 14:27:11 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mark Harfouche
2018-06-18 21:03:35 UTC
Seems like they are using some functions that are only defined in ``` Release 3.5.2 (Public Release - 2002-12-23) - Updated version name and implementation name to reflect release 3.5.2 Affects: dcmdata/include/dcuid.h - Updated documentation to reflect changes in 3.5.2 Affects: README Added: ANNOUNCE.352 ``` and that don't seem to be defined in 3.6.2 the version that comes with fedora 28 I really can't parse what you are asking for here. vtk is at version 7.1.1 from 2017 since Fedora 26+. Dam, sorry, this was supposed to be filed against vxl Trying to unbundle the dcmtk library yields these errors for me
```
[ 52%] Building CXX object core/vil/CMakeFiles/vil.dir/file_formats/vil_dicom.cxx.o
cd /builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil && /usr/bin/c++ -DOPJ_STATIC -DVXL_LEGACY_ERROR_REPORTING -DVXL_WARN_DEPRECATED -DVXL_WARN_DEPRECATED_ONCE -Dvil_EXPORTS -I/builddir/build/BUILD/vxl-1.17.0.2018.06.18/vcl -I/builddir/build/BUILD/vxl-1.17.0.2018.06.18/core -I/builddir/build/BUILD/vxl-1.17.0.2018.06.18/v3p/openjpeg2 -I/builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -DNDEBUG -fPIC -Wno-undefined-var-template -o CMakeFiles/vil.dir/file_formats/vil_dicom.cxx.o -c /builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil/file_formats/vil_dicom.cxx
/builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil/file_formats/vil_dicom.cxx: In instantiation of 'void {anonymous}::convert_src_type(const InT*, DcmPixelData*, unsigned int, Uint16, Uint16, Uint16, Uint16, DiInputPixel*&, vil_pixel_format&) [with InT = short unsigned int; Uint16 = short unsigned int]':
/builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil/file_formats/vil_dicom.cxx:1050:105: required from here
/builddir/build/BUILD/vxl-1.17.0.2018.06.18/core/vil/file_formats/vil_dicom.cxx:980:20: error: no matching function for call to 'DiInputPixelTemplate<short unsigned int, unsigned char>::DiInputPixelTemplate(DcmPixelData*&, Uint16&, Uint16&, Uint16&, int, unsigned int&)'
pixel_data = new DiInputPixelTemplate<InT,Uint8>( pixels, alloc, stored, high, 0, num_samples );
```
Created attachment 1452741 [details]
Proposed .spec file for a 2018 build
Requires bundling dcmtk
Most (all) previous patches are now not necessary.
source created with
```
git clone git:vxl/vxl.git
cd vxl
git archive --format=tar.gz HEAD >vxl-1.17.0-2018.06.18.tar.gz
```
Created attachment 1452742 [details] Patch 27 that helps with dcmtk I think I have this wrong, and that we also require the inclusion of FindDCMTK somewhere appropriate to unbundle dcmtk https://cmake.org/cmake/help/v3.5/module/FindDCMTK.html Created attachment 1452761 [details]
Proposed .spec file for a 2018 build
Unbundles rply from the previous submitted patch
needs and updated patch3
Created attachment 1452762 [details]
Updated patch 0003 Use system rply
Required updates to patch 0003 to use system rply
And on Copr in case anybody needs this before it is finalized https://copr.fedorainfracloud.org/coprs/hmaarrfk/itk/ Igor - what's the status here? I'm looking to update VTK to 8.1.1 and running into issues with the outdated vxl lib as well. See https://copr.fedorainfracloud.org/coprs/orion/vtk8 Mark - perhaps an updated pull request would be helpful? I think there was a commit after you made your propsed spec. Orion, I have since mostly moved to Ubuntu + conda. Fedora's compilers were too new and bleeding edge. Finally, the lib64 vs lib cause many issues compiling things that I didn't want to keep dealing with. I'm sorry, I probably can't be of any more help. *** This bug has been marked as a duplicate of bug 1371436 *** |