Bug 1592573
| Summary: | Default dialog entries not localized when ordering catalog item in French | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | David Luong <dluong> |
| Component: | UI - OPS | Assignee: | Milan Zázrivec <mzazrivec> |
| Status: | CLOSED ERRATA | QA Contact: | Niyaz Akhtar Ansari <nansari> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.9.0 | CC: | cpelland, hkataria, jprause, lavenel, mpovolny, mzazrivec, nansari, obarenbo, simaishi |
| Target Milestone: | GA | ||
| Target Release: | 5.10.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 5.10.0.11 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-07 23:03:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | Bug | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | CFME Core | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Luong
2018-06-18 21:55:26 UTC
This part of our UI was re-written from ruby to angular recently. I'm re-assigning this bz over to chhale, who's the author (iirc) and knows the code much better than me. Thanks. In looking at this issue, the service dialog component is not actually responsible for localizing those drop down options. The dialog editor is responsible for creating those options when the dialog is created. Going to reassign to the OPS UI team to take a look and ensure dialog editor is localizing the default selected values when it creates them. https://github.com/ManageIQ/manageiq/pull/17789 https://github.com/ManageIQ/manageiq-ui-classic/pull/4395 New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/f429ed38afa3f72cf0f64d3e4233714e852de215 commit f429ed38afa3f72cf0f64d3e4233714e852de215 Author: Milan Zazrivec <mzazrivec> AuthorDate: Wed Aug 1 09:11:59 2018 -0400 Commit: Milan Zazrivec <mzazrivec> CommitDate: Wed Aug 1 09:11:59 2018 -0400 Apply gettext to initial & error service dialog values https://bugzilla.redhat.com/show_bug.cgi?id=1592573 app/models/dialog_field_check_box.rb | 2 +- app/models/dialog_field_date_control.rb | 2 +- app/models/dialog_field_drop_down_list.rb | 2 +- app/models/dialog_field_radio_button.rb | 2 +- app/models/dialog_field_sorted_item.rb | 6 +- app/models/dialog_field_text_box.rb | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/783d9676da2a19e36f72c71cf353b275dd66d193 commit 783d9676da2a19e36f72c71cf353b275dd66d193 Author: Milan Zazrivec <mzazrivec> AuthorDate: Wed Aug 1 09:14:17 2018 -0400 Commit: Milan Zazrivec <mzazrivec> CommitDate: Wed Aug 1 09:14:17 2018 -0400 Service Dialog: Apply gettext on initial values https://bugzilla.redhat.com/show_bug.cgi?id=1592573 app/assets/javascripts/controllers/dialog_editor/dialog_editor_controller.js | 5 + app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 14 + app/views/miq_ae_customization/_dialog_sample.html.haml | 2 +- 3 files changed, 20 insertions(+), 1 deletion(-) Verified in Version 5.10.0.21.20181023151612_4c11b0d Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0212 |