Bug 1592573 - Default dialog entries not localized when ordering catalog item in French
Summary: Default dialog entries not localized when ordering catalog item in French
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.10.0
Assignee: Milan Zázrivec
QA Contact: Niyaz Akhtar Ansari
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-18 21:55 UTC by David Luong
Modified: 2022-03-13 15:08 UTC (History)
9 users (show)

Fixed In Version: 5.10.0.11
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-07 23:03:07 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 3724611 0 None None None 2018-11-29 21:41:40 UTC
Red Hat Product Errata RHSA-2019:0212 0 None None None 2019-02-07 23:03:23 UTC

Description David Luong 2018-06-18 21:55:26 UTC
Description of problem:
In the dialogs when ordering a catalog item, fields such as <None> and "Nothing selected" are not localized.

Version-Release number of selected component (if applicable):
5.9.2

How reproducible:
Always

Steps to Reproduce:
1.  Choose French locale
2.  Order a service catalog
3.

Actual results:
Displays English <None> and "nothing selected"

Expected results:
French versions of the above

Additional info:

Comment 6 Milan Zázrivec 2018-06-25 06:46:10 UTC
This part of our UI was re-written from ruby to angular recently.

I'm re-assigning this bz over to chhale, who's
the author (iirc) and knows the code much better than me.

Thanks.

Comment 7 Chris Hale 2018-06-25 14:14:47 UTC
In looking at this issue, the service dialog component is not actually responsible for localizing those drop down options.  The dialog editor is responsible for creating those options when the dialog is created.  Going to reassign to the OPS UI team to take a look and ensure dialog editor is localizing the default selected values when it creates them.

Comment 14 CFME Bot 2018-08-01 19:51:14 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/f429ed38afa3f72cf0f64d3e4233714e852de215
commit f429ed38afa3f72cf0f64d3e4233714e852de215
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Aug  1 09:11:59 2018 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Aug  1 09:11:59 2018 -0400

    Apply gettext to initial & error service dialog values

    https://bugzilla.redhat.com/show_bug.cgi?id=1592573

 app/models/dialog_field_check_box.rb | 2 +-
 app/models/dialog_field_date_control.rb | 2 +-
 app/models/dialog_field_drop_down_list.rb | 2 +-
 app/models/dialog_field_radio_button.rb | 2 +-
 app/models/dialog_field_sorted_item.rb | 6 +-
 app/models/dialog_field_text_box.rb | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

Comment 15 CFME Bot 2018-08-06 12:42:21 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/783d9676da2a19e36f72c71cf353b275dd66d193
commit 783d9676da2a19e36f72c71cf353b275dd66d193
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Aug  1 09:14:17 2018 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Aug  1 09:14:17 2018 -0400

    Service Dialog: Apply gettext on initial values

    https://bugzilla.redhat.com/show_bug.cgi?id=1592573

 app/assets/javascripts/controllers/dialog_editor/dialog_editor_controller.js | 5 +
 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 14 +
 app/views/miq_ae_customization/_dialog_sample.html.haml | 2 +-
 3 files changed, 20 insertions(+), 1 deletion(-)

Comment 16 Niyaz Akhtar Ansari 2018-10-31 08:00:19 UTC
Verified in Version 5.10.0.21.20181023151612_4c11b0d

Comment 17 errata-xmlrpc 2019-02-07 23:03:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0212


Note You need to log in before you can comment on or make changes to this bug.