Bug 1594399

Summary:	RFE: Add StartupWMClass also to bundled .desktop files such as wine-notepad.desktop
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	wine	Assignee:	Michael Cronenworth <mike>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	andreas.bierfert, besser82, mike
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	wine-3.11-1.fc28 wine-3.11-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-28 14:09:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rex Dieter 2018-06-22 20:36:21 UTC

per upstream bug,
https://bugs.winehq.org/show_bug.cgi?id=45245

"... wine adds StartupWMClass=foo.exe to the .desktop files it generates, matching the name/instance string of the WM_CLASS it sets on wine windows. This has massively improved the integration of Wine clients with desktop environments and made the users of KDE Plasma (and likely Gnome Shell, which works the same way) much happier.

However, we've recently noticed that wine .desktop files installed in /usr and presumably pre-generated/bundled haven't been updated in the same way. For example, `wine-notepad.desktop` doesn't contain StartupWMClass=notepad.exe, so the integration doesn't work there.

Fixing this up would allow the "Pin" and "Start New Instance" actions and even listings of recently open files to work in the context menu of tasks like Notepad in KDE Plasma, for example."

Comment 1 Rex Dieter 2018-06-22 20:36:48 UTC

When/if I find time, I can work on a PR to implement this.

Comment 2 Michael Cronenworth 2018-06-23 13:36:01 UTC

Wine does not add StartupWMClass to its self-generated files. It does add "StartupNotify=true" though.

I am a very active maintainer so there is no need to treat wine as a "no one is working on it" package. I'm here. I'll work on it.

Comment 3 Michael Cronenworth 2018-06-23 13:38:09 UTC

OK, I see WMClass was added very recently.

https://source.winehq.org/git/wine.git/blobdiff/50b033691494186421f04d518a9eb249d8a348cd..917e86dd7a4cca1da47262caaded2bef9e022f99:/programs/winemenubuilder/winemenubuilder.c

I can look into it.

Comment 4 Rex Dieter 2018-06-23 15:04:53 UTC

<nod>, sorry for not making that clear, the upstream .desktop files are fine, it's the ones only bundled in downstream packaging that needs adjustment.

Comment 5 Michael Cronenworth 2018-06-24 15:17:26 UTC

Committed. Pushing a wine 3.11 update soon that will include this.

https://src.fedoraproject.org/rpms/wine/c/09cb9e29740199afa0fcd2e8352cc2cdda179b71?branch=master

Comment 6 Fedora Update System 2018-06-24 20:01:29 UTC

wine-3.11-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-695156bb57

Comment 7 Fedora Update System 2018-06-24 20:03:13 UTC

wine-3.11-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-338a6b659a

Comment 8 Fedora Update System 2018-06-25 10:00:17 UTC

wine-3.11-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-338a6b659a

Comment 9 Fedora Update System 2018-06-25 12:19:35 UTC

wine-3.11-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-695156bb57

Comment 10 Fedora Update System 2018-06-28 14:09:05 UTC

wine-3.11-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-07-03 14:11:26 UTC

wine-3.11-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.