Bug 1594399 - RFE: Add StartupWMClass also to bundled .desktop files such as wine-notepad.desktop
Summary: RFE: Add StartupWMClass also to bundled .desktop files such as wine-notepad.d...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: wine
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael Cronenworth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-22 20:36 UTC by Rex Dieter
Modified: 2018-07-03 14:11 UTC (History)
3 users (show)

Fixed In Version: wine-3.11-1.fc28 wine-3.11-1.fc27
Clone Of:
Environment:
Last Closed: 2018-06-28 14:09:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2018-06-22 20:36:21 UTC
per upstream bug,
https://bugs.winehq.org/show_bug.cgi?id=45245

"... wine adds StartupWMClass=foo.exe to the .desktop files it generates, matching the name/instance string of the WM_CLASS it sets on wine windows. This has massively improved the integration of Wine clients with desktop environments and made the users of KDE Plasma (and likely Gnome Shell, which works the same way) much happier.

However, we've recently noticed that wine .desktop files installed in /usr and presumably pre-generated/bundled haven't been updated in the same way. For example, `wine-notepad.desktop` doesn't contain StartupWMClass=notepad.exe, so the integration doesn't work there.

Fixing this up would allow the "Pin" and "Start New Instance" actions and even listings of recently open files to work in the context menu of tasks like Notepad in KDE Plasma, for example."

Comment 1 Rex Dieter 2018-06-22 20:36:48 UTC
When/if I find time, I can work on a PR to implement this.

Comment 2 Michael Cronenworth 2018-06-23 13:36:01 UTC
Wine does not add StartupWMClass to its self-generated files. It does add "StartupNotify=true" though.

I am a very active maintainer so there is no need to treat wine as a "no one is working on it" package. I'm here. I'll work on it.

Comment 4 Rex Dieter 2018-06-23 15:04:53 UTC
<nod>, sorry for not making that clear, the upstream .desktop files are fine, it's the ones only bundled in downstream packaging that needs adjustment.

Comment 5 Michael Cronenworth 2018-06-24 15:17:26 UTC
Committed. Pushing a wine 3.11 update soon that will include this.

https://src.fedoraproject.org/rpms/wine/c/09cb9e29740199afa0fcd2e8352cc2cdda179b71?branch=master

Comment 6 Fedora Update System 2018-06-24 20:01:29 UTC
wine-3.11-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-695156bb57

Comment 7 Fedora Update System 2018-06-24 20:03:13 UTC
wine-3.11-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-338a6b659a

Comment 8 Fedora Update System 2018-06-25 10:00:17 UTC
wine-3.11-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-338a6b659a

Comment 9 Fedora Update System 2018-06-25 12:19:35 UTC
wine-3.11-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-695156bb57

Comment 10 Fedora Update System 2018-06-28 14:09:05 UTC
wine-3.11-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-07-03 14:11:26 UTC
wine-3.11-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.