Bug 1594408
| Summary: | [v2v] Remove migration plans from Service Catalog Items | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Brett Thurber <bthurber> | ||||||
| Component: | UI - OPS | Assignee: | Hui Song <hsong> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadnyawalk Tale <ytale> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.9.0 | CC: | cpelland, gmccullo, hkataria, jprause, kkulkarn, lavenel, mpovolny, obarenbo, simaishi, smallamp, ytale | ||||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||||
| Target Release: | 5.10.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | v2v | ||||||||
| Fixed In Version: | 5.10.0.11 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1610729 (view as bug list) | Environment: | |||||||
| Last Closed: | 2019-02-11 13:59:30 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1564236, 1598565, 1610729 | ||||||||
| Attachments: |
|
||||||||
Addressing needinfo. PR https://github.com/ManageIQ/manageiq/pull/17748 is the one we need on the backend which introduces the "public_service_templates" scope. The manageiq-schema PR (and a future PR) will promote the "internaL" column for the reserves_mixin to a real service_template column. New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/5fc42f8d2d69544153feb0dd760484f37f6e4e2f commit 5fc42f8d2d69544153feb0dd760484f37f6e4e2f Author: Harpreet Kataria <hkataria> AuthorDate: Tue Jul 10 14:49:23 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 10 14:49:23 2018 -0400 Changes to exclude service templates marked as service_type = internal This is to exclude Migration Plan Service Templates from Catalogs Explorer. Backend changes to support this are in https://github.com/ManageIQ/manageiq/pull/17681 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408 app/controllers/catalog_controller.rb | 9 +- app/presenters/tree_builder_catalog_items.rb | 4 +- app/presenters/tree_builder_service_catalog.rb | 4 +- spec/controllers/catalog_controller_spec.rb | 6 +- 4 files changed, 12 insertions(+), 11 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/f7144c5588385e4fc42d1c16c20a9f0a24bf94f7 commit f7144c5588385e4fc42d1c16c20a9f0a24bf94f7 Author: Harpreet Kataria <hkataria> AuthorDate: Sat Jul 14 12:58:17 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Sat Jul 14 12:58:17 2018 -0400 replaced where clauses to use named_scope where possible Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408 app/controllers/catalog_controller.rb | 7 +- app/presenters/tree_builder_catalog_items.rb | 4 +- app/presenters/tree_builder_service_catalog.rb | 4 +- 3 files changed, 7 insertions(+), 8 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/e61f27397ec51d070a27ef2443f08cfda8e2569c commit e61f27397ec51d070a27ef2443f08cfda8e2569c Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jul 16 09:16:36 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jul 16 09:16:36 2018 -0400 addressed rubocop/codeclimate warnings Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408 app/controllers/catalog_controller.rb | 19 +- app/presenters/tree_builder_catalog_items.rb | 2 +- app/presenters/tree_builder_service_catalog.rb | 4 +- 3 files changed, 16 insertions(+), 9 deletions(-) Created attachment 1474657 [details]
issue_5.10.0.8.mp4
Not fixed! I can still see plans in catalog_items, just that now it is little bit covered.
So earlier, plans were showing under catalog_item accordion in a tree (under Unassigned section) and now it is not showing in tree; but you can still find it with small extra steps, *click on `Unassigned`* and you will find plan are still there.
Also checked SSUI which is working as expected.
Checked on: 5.10.0.8.20180801220537_afb552b
(P.S. Video attached)
Marking FailedQA as behavior is not expected. FYI, if you delete plan from catalog_item it actually deletes plan from migration page. New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/74a8edaa152b3e0af31571b5622c1b1e9d09c07f commit 74a8edaa152b3e0af31571b5622c1b1e9d09c07f Author: hsong-rh <hsong> AuthorDate: Thu Jul 19 15:14:43 2018 -0400 Commit: hsong-rh <hsong> CommitDate: Thu Jul 19 15:14:43 2018 -0400 Add internal column to ServiceTemplate table https://bugzilla.redhat.com/show_bug.cgi?id=1594408 db/migrate/20180719163110_add_internal_to_service_template.rb | 17 + spec/migrations/20180719163110_add_internal_to_service_template_spec.rb | 23 + 2 files changed, 40 insertions(+) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/5362d75d42525568260cbe51e3b066ab665d95ec commit 5362d75d42525568260cbe51e3b066ab665d95ec Author: Harpreet Kataria <hkataria> AuthorDate: Tue Aug 14 10:39:03 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 14 10:39:03 2018 -0400 Added missing 'public_service_templates' scope Added 'public_service_templates' scope when fetching right side list for unassigned folder node Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408 app/controllers/catalog_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Fixed! I can not see any plan in catalog item and also last unassigned thing got patched. Verified on: 5.10.0.17.20180927011235_1b5cf54 (PS. Checked https://bugzilla.redhat.com/attachment.cgi?bugid=1565049 and it is not yet fixed.) |
Created attachment 1453852 [details] Catalog Items Description of problem: When creating migration plans in the Migration plugin, they also appear under Services > Catalogs > Catalog Items. Version-Release number of selected component (if applicable): 5.9.3 and latest MiQ nightly How reproducible: Everytime Steps to Reproduce: 1. In Migration plugin, create a migration plan 2. Navigate to Services > Catalogs > Catalog Items 3. Migration plans are listed Actual results: Migration plans are listed under: Services > Catalogs > Catalog Items Expected results: Migration plans do not appear in the Service Catalog Additional info: