Bug 1610729 - Remove migration plans from Service Catalog Items
Summary: Remove migration plans from Service Catalog Items
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.9.4
Assignee: Hui Song
QA Contact: Yadnyawalk Tale
URL:
Whiteboard:
Depends On: 1594408
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-01 10:17 UTC by Satoe Imaishi
Modified: 2018-09-05 12:56 UTC (History)
12 users (show)

Fixed In Version: 5.9.4.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1594408
Environment:
Last Closed: 2018-09-05 12:56:39 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
issue_5.9.4.3.mp4 (564.56 KB, video/mp4)
2018-08-09 12:18 UTC, Yadnyawalk Tale
no flags Details
earlier_behavior_5.9.4.0.mp4 (336.48 KB, video/mp4)
2018-08-09 12:22 UTC, Yadnyawalk Tale
no flags Details
5.9.4.4_proof.png (65.44 KB, image/png)
2018-08-17 11:56 UTC, Yadnyawalk Tale
no flags Details
My_Order_SSUI.png (85.89 KB, image/png)
2018-08-17 11:57 UTC, Yadnyawalk Tale
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1565049 0 medium CLOSED [upstream][v2v] Migration requests are appearing in 'My Order' of SSUI 2021-02-22 00:41:40 UTC

Internal Links: 1565049

Comment 2 CFME Bot 2018-08-01 10:21:10 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/685c571bef061200b7a26b8aa3b4f3577014733e
commit 685c571bef061200b7a26b8aa3b4f3577014733e
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jul 31 12:07:50 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Tue Jul 31 12:07:50 2018 -0400

    Merge pull request #17748 from hsong-rh/add_internal_to_service_template

    Add internal column to service template for transformation plan
    (cherry picked from commit 2a66cb59e26816c7296896620b5b7731b350943d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1610729

 app/models/service_template.rb | 3 +
 app/models/service_template_transformation_plan.rb | 2 +
 spec/models/service_template_transformation_plan_spec.rb | 11 +
 3 files changed, 16 insertions(+)

Comment 5 CFME Bot 2018-08-06 13:37:28 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/24bc296be8024b360cb14837ac60e34d3c741c93
commit 24bc296be8024b360cb14837ac60e34d3c741c93
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Jul 31 18:24:17 2018 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Jul 31 18:24:17 2018 -0400

    Merge pull request #4274 from h-kataria/service_templates_to_exclude_migration_plans

    Changes to exclude service templates marked as service_type = internal
    (cherry picked from commit 3acd7630eadecd477892075a2d4b222a16547940)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729

 app/controllers/catalog_controller.rb | 25 +-
 app/presenters/tree_builder_catalog_items.rb | 4 +-
 app/presenters/tree_builder_service_catalog.rb | 4 +-
 spec/controllers/catalog_controller_spec.rb | 6 +-
 4 files changed, 23 insertions(+), 16 deletions(-)

Comment 6 Yadnyawalk Tale 2018-08-09 12:18:52 UTC
Created attachment 1474664 [details]
issue_5.9.4.3.mp4

Not fixed! I can still see plans in catalog_items, just that now it is little bit covered. 

So earlier, plans were showing under catalog_item accordion in a tree (under Unassigned section) and now it is not showing in tree; but you can still find it with small extra steps, *click on `Unassigned`* and you will find plan are still there.

Also checked SSUI which is working as expected.
Checked on: 5.9.4.3.20180808144238_a20955a 
Marking FailedQA as behavior is not expected.

(P.S. Video attached)

Comment 7 Yadnyawalk Tale 2018-08-09 12:22:14 UTC
Created attachment 1474667 [details]
earlier_behavior_5.9.4.0.mp4

Comment 8 Yadnyawalk Tale 2018-08-09 12:22:35 UTC
FYI, if you delete plan from catalog_item it actually deletes plan from migration page.

Comment 19 CFME Bot 2018-08-14 21:47:28 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/23574ded21541a4628e7aa05e0b8b8970f8b2fbd
commit 23574ded21541a4628e7aa05e0b8b8970f8b2fbd
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Aug 14 12:36:20 2018 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Aug 14 12:36:20 2018 -0400

    Merge pull request #4473 from h-kataria/exclude_migration_template_unassigned_folder

    Added missing 'public_service_templates' scope
    (cherry picked from commit 0b219e9248c8814caf0ed25831cbf69e41a2fcf7)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729

 app/controllers/catalog_controller.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 20 Yadnyawalk Tale 2018-08-17 11:56:52 UTC
Created attachment 1476602 [details]
5.9.4.4_proof.png

Fixed! Mentioned bug is patched and migration plans are not displaying in Unassigned catalog section (last time it was there). 

Also in SSUI, service catalog don't show migration plan, which is what we have expected.

(My small concern is - ordered migration plan still get displayed in My Order section of SSUI but it is covering through another Bugzilla issue so verifying this issue)

Verified on: 5.9.4.4.20180816162527_c00eb23

Comment 21 Yadnyawalk Tale 2018-08-17 11:57:28 UTC
Created attachment 1476603 [details]
My_Order_SSUI.png

Comment 22 CFME Bot 2018-08-21 15:28:25 UTC
New commit detected on ManageIQ/manageiq-schema/master:

https://github.com/ManageIQ/manageiq-schema/commit/296d94413596d44908c5849a974ed6b3be9693f9
commit 296d94413596d44908c5849a974ed6b3be9693f9
Author:     hsong-rh <hsong>
AuthorDate: Fri Aug 10 11:22:34 2018 -0400
Commit:     hsong-rh <hsong>
CommitDate: Fri Aug 10 11:22:34 2018 -0400

    Update default of internal attribute in service template

    https://bugzilla.redhat.com/show_bug.cgi?id=1610729

 db/migrate/20180810144738_update_default_internal_attribute.rb | 11 +
 spec/migrations/20180810144738_update_default_internal_attribute_spec.rb | 23 +
 2 files changed, 34 insertions(+)


Note You need to log in before you can comment on or make changes to this bug.