Bug 1600069

Summary:	[Tests] PEP8 fails
Product:	Red Hat OpenStack	Reporter:	Arie Bregman <abregman>
Component:	python-networking-ovn	Assignee:	Lucas Alvares Gomes <lmartins>
Status:	CLOSED ERRATA	QA Contact:	Eran Kuris <ekuris>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	13.0 (Queens)	CC:	abregman, apevec, jschluet, lhh, lmartins, majopela, nyechiel, sclewis
Target Milestone:	z3	Keywords:	AutomationBlocker, Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-13 23:32:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Arie Bregman 2018-07-11 11:03:35 UTC

Description of problem:

Styling check fails in OSP 13 branch (as well as any othe branch we have in d/s).

To reproduce you can simply run locally tox -e pep8 in the repo.

Comment 4 Lucas Alvares Gomes 2018-07-24 14:24:24 UTC

Hi Arie,

This has already been fixed upstream and backported to stable/queens [0]. I looked at the rhos-13.0-patches branch and the patch is not there yet so I guess the fix will be applied on the next rebase.

I can confirm that I've manually cherry-picked [0] onto rhos-13.0-patches and it works.

[0] https://review.openstack.org/#/c/560893/

Comment 5 Arie Bregman 2018-07-25 06:57:45 UTC

Thanks for the update Lucas.

Let's close this bug once the patch is in the branch.

Comment 6 Jon Schlueter 2018-08-30 21:56:04 UTC

Patch already landed is this good to close per https://bugzilla.redhat.com/show_bug.cgi?id=1600069#c5

Comment 7 Lucas Alvares Gomes 2018-08-31 08:34:03 UTC

(In reply to Jon Schlueter from comment #6)
> Patch already landed is this good to close per
> https://bugzilla.redhat.com/show_bug.cgi?id=1600069#c5

Sounds good, just checked and the patch is included in the rhos-13.0-patches and 14 branches.

Closing it.

Comment 12 errata-xmlrpc 2018-11-13 23:32:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3614