Bug 1600069 - [Tests] PEP8 fails
Summary: [Tests] PEP8 fails
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-networking-ovn
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z3
: 13.0 (Queens)
Assignee: Lucas Alvares Gomes
QA Contact: Eran Kuris
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-11 11:03 UTC by Arie Bregman
Modified: 2019-09-09 16:39 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-13 23:32:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 560893 0 None stable/queens: MERGED networking-ovn: Fix gate: PEP8 and ovs-master jobs (I9dca4ba494082a0bf37833b13b05609c715a492d) 2018-08-30 21:54:11 UTC
Red Hat Product Errata RHBA-2018:3614 0 None None None 2018-11-13 23:34:31 UTC

Description Arie Bregman 2018-07-11 11:03:35 UTC
Description of problem:

Styling check fails in OSP 13 branch (as well as any othe branch we have in d/s).

To reproduce you can simply run locally tox -e pep8 in the repo.

Comment 4 Lucas Alvares Gomes 2018-07-24 14:24:24 UTC
Hi Arie,

This has already been fixed upstream and backported to stable/queens [0]. I looked at the rhos-13.0-patches branch and the patch is not there yet so I guess the fix will be applied on the next rebase.

I can confirm that I've manually cherry-picked [0] onto rhos-13.0-patches and it works.

[0] https://review.openstack.org/#/c/560893/

Comment 5 Arie Bregman 2018-07-25 06:57:45 UTC
Thanks for the update Lucas.

Let's close this bug once the patch is in the branch.

Comment 6 Jon Schlueter 2018-08-30 21:56:04 UTC
Patch already landed is this good to close per https://bugzilla.redhat.com/show_bug.cgi?id=1600069#c5

Comment 7 Lucas Alvares Gomes 2018-08-31 08:34:03 UTC
(In reply to Jon Schlueter from comment #6)
> Patch already landed is this good to close per
> https://bugzilla.redhat.com/show_bug.cgi?id=1600069#c5

Sounds good, just checked and the patch is included in the rhos-13.0-patches and 14 branches.

Closing it.

Comment 12 errata-xmlrpc 2018-11-13 23:32:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3614


Note You need to log in before you can comment on or make changes to this bug.