Bug 1602263

Summary:	Disabling Thinpool when compression and deduplication is enabled on a device
Product:	[oVirt] cockpit-ovirt	Reporter:	bipin <bshetty>
Component:	Gdeploy	Assignee:	Gobinda Das <godas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bipin <bshetty>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.11.7	CC:	bugs, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone:	ovirt-4.2.5	Flags:	rule-engine: ovirt-4.2? rule-engine: blocker+ bshetty: planning_ack? rule-engine: devel_ack+ bshetty: testing_ack+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.11.31-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1602261	Environment:
Last Closed:	2018-07-31 15:28:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1602261, 1602286

Description bipin 2018-07-18 06:01:51 UTC

+++ This bug was initially created as a clone of Bug #1602261 +++

Description of problem:
Currently in RHHI, when thinpool and VDO(compression and deduplication) are enabled for a device it affects the discard functionality. Basically the thinpool has minimum 64kb size discard set and VDO has its default as 4kb. Since thinp falls above VDO in RHHI stack , it disables the discard passdown. This bug is raised to make sure the thinp is disabled, so that the VDO  max_discard_sectors=4 is enabled.


Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard-0.11.30-1.el7ev.noarch
ansible-2.6.1-1.el7ae.noarch
gdeploy-2.0.2-27.el7rhgs.noarch
vdo-6.1.0.168-18.x86_64
kmod-kvdo-6.1.0.171-17.el7_5.x86_64

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:


Additional info:

This is raised based on the bug 1600156

Comment 1 bipin 2018-07-25 10:10:00 UTC

Verified the bug on cockpit-ovirt-0.11.31-1.
Attaching the screenshot from cockpit

Steps:
====
1.Start the gluster deployment 
2.Move towards the brick tab and check the enable compression and deduplication checkbox
3.The thinpool gets unchecked for that device
4.Complete the deployment and the VDO device is created without thinp


CLI output:
==========
sdb                                                                8:16   0    20T  0 disk 
└─vdo_sdb                                                        253:14   0  50.8T  0 vdo  
  ├─gluster_vg_sdb-gluster_lv_engine                             253:19   0   100G  0 lvm  /gluster_bricks/engine
  ├─gluster_vg_sdb-gluster_lv_data                               253:20   0  1000G  0 lvm  /gluster_bricks/data
  └─gluster_vg_sdb-gluster_lv_vmstore                            253:21   0     4T  0 lvm  /gluster_bricks/vmstore

Comment 2 bipin 2018-07-25 10:10:39 UTC

Created attachment 1470494 [details]
Cockpit_UI_Verified

Comment 3 Sandro Bonazzola 2018-07-31 15:28:38 UTC

This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.