Bug 1608420

Summary: [RFE] CFME 5.9.4 - pre/post playbook support
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Marco Berube <mberube>
Status: CLOSED CURRENTRELEASE QA Contact: Kedar Kulkarni <kkulkarn>
Severity: low Docs Contact:
Priority: high    
Version: 5.9.0CC: bthurber, cpelland, dmisharo, fdupont, gmccullo, hkataria, jhardy, jprause, kkulkarn, lavenel, mberube, mpovolny, obarenbo, simaishi, smallamp
Target Milestone: GAKeywords: FutureFeature, RFE, ZStream
Target Release: 5.9.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.9.4.4 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1564250 Environment:
Last Closed: 2018-09-05 12:56:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1564250, 1613935    
Bug Blocks:    

Comment 2 CFME Bot 2018-07-25 13:51:10 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/d45d1019b6ff0647c0919a2affc6a22ef3819684
commit d45d1019b6ff0647c0919a2affc6a22ef3819684
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Jul  5 09:54:50 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Thu Jul  5 09:54:50 2018 -0400

    Merge pull request #17627 from lfu/v2v_pre_post_ansibile_service

    Support for v2v pre/post Ansible playbook service.
    (cherry picked from commit ce4d2b5ac92795a615cb7ae98b211bbac205ee57)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 app/models/service_template_transformation_plan.rb | 30 +-
 app/models/service_template_transformation_plan_task.rb | 8 +
 spec/models/service_template_transformation_plan_spec.rb | 14 +-
 spec/models/service_template_transformation_plan_task_spec.rb | 24 +-
 4 files changed, 64 insertions(+), 12 deletions(-)


https://github.com/ManageIQ/manageiq/commit/c217a7b63a89deadc6abddad450d2bd380200dab
commit c217a7b63a89deadc6abddad450d2bd380200dab
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Jul  9 16:10:19 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Jul  9 16:10:19 2018 -0400

    Merge pull request #17674 from lfu/v2v_pre_post_ansibile_service

    The vm_id coming in from API is a string.
    (cherry picked from commit 1bb13c5e8d627d50b9cede9505c43392f11f3bec)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 app/models/service_template_transformation_plan.rb | 8 +-
 spec/models/service_template_transformation_plan_spec.rb | 4 +-
 spec/models/service_template_transformation_plan_task_spec.rb | 4 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

Comment 5 CFME Bot 2018-07-25 14:12:47 UTC
New commit detected on ManageIQ/manageiq-automation_engine/gaprindashvili:

https://github.com/ManageIQ/manageiq-automation_engine/commit/d520155cae3769dbeee7ef99b21002d8404f43f5
commit d520155cae3769dbeee7ef99b21002d8404f43f5
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Jul  5 10:06:11 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Thu Jul  5 10:06:11 2018 -0400

    Merge pull request #192 from lfu/v2v_pre_post_ansibile_service

    Support for v2v pre/post Ansible playbook service.
    (cherry picked from commit a9519fbd4db342cd1d8fd2d4de7319ad0c695e85)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 lib/miq_automation_engine/service_models/miq_ae_service_service_template_transformation_plan_task.rb | 2 +
 1 file changed, 2 insertions(+)

Comment 6 CFME Bot 2018-07-25 14:17:08 UTC
New commits detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/fb6f12ceff23a21bbdb891431ff31b43820bc8ca
commit fb6f12ceff23a21bbdb891431ff31b43820bc8ca
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Jul 19 08:06:54 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Thu Jul 19 08:06:54 2018 -0400

    Merge pull request #355 from fdupont-redhat/v2v_pre_post_migration_playbook_support

    Add support for pre/post-migration playbook
    (cherry picked from commit f5fdc8293ac754a37674920607d7743392d94fcd)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 content/automate/ManageIQ/Transformation/Ansible.class/__class__.yaml | 33 +
 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/checkplaybookasaservice.rb | 51 +
 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/checkplaybookasaservice.yaml | 33 +
 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/launchplaybookasaservice.rb | 45 +
 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/launchplaybookasaservice.yaml | 33 +
 content/automate/ManageIQ/Transformation/Ansible.class/_missing.yaml | 12 +
 content/automate/ManageIQ/Transformation/Infrastructure/VM/rhevm.class/__methods__/checkpoweredon.rb | 5 +-
 content/automate/ManageIQ/Transformation/Infrastructure/VM/rhevm.class/__methods__/checkpoweredon.yaml | 2 -
 content/automate/ManageIQ/Transformation/StateMachines/Ansible.class/__class__.yaml | 133 +
 content/automate/ManageIQ/Transformation/StateMachines/Ansible.class/transformationplaybook.yaml | 27 +
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformation.yaml | 22 +-
 11 files changed, 387 insertions(+), 9 deletions(-)


https://github.com/ManageIQ/manageiq-content/commit/f4346907b20e99680c010b4e595581fcedff4c3f
commit f4346907b20e99680c010b4e595581fcedff4c3f
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jul 24 11:18:47 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Tue Jul 24 11:18:47 2018 -0400

    Merge pull request #369 from fdupont-redhat/v2v_fix_retry_for_playbook

    Refactor set retry for pre/post migration playbooks
    (cherry picked from commit ac447a3e4bfb96f3a283be8d37815bc567f1241b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/checkplaybookasaservice.rb | 9 +-
 1 file changed, 5 insertions(+), 4 deletions(-)


https://github.com/ManageIQ/manageiq-content/commit/2b6c11eabcf96f51fce80ab11e9c3b20de0629f2
commit 2b6c11eabcf96f51fce80ab11e9c3b20de0629f2
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jul 24 11:45:24 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Tue Jul 24 11:45:24 2018 -0400

    Merge pull request #370 from fdupont-redhat/v2v_fix_playbook_hook_passing

    Fix hook string passing for pre/post-migration playbooks
    (cherry picked from commit 54eb45d355954d6c9e7932d092586ea12a46e286)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 content/automate/ManageIQ/Transformation/StateMachines/Ansible.class/transformationplaybook.yaml | 4 +-
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2018-07-31 01:01:42 UTC
New commit detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/1539b7d2e8dd168e55706a1923e312ac5d7340ca
commit 1539b7d2e8dd168e55706a1923e312ac5d7340ca
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Jul 30 08:19:52 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Jul 30 08:19:52 2018 -0400

    Merge pull request #380 from fdupont-redhat/v2v_allow_playbooks_on_powered_off_vm

    Allow running playbook against powered off VM
    (cherry picked from commit c38ef4bc77b024904a2f7f45225801ca39e94789)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

 content/automate/ManageIQ/Transformation/Ansible.class/__methods__/launchplaybookasaservice.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 11 Kedar Kulkarni 2018-08-08 17:27:07 UTC
Blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1613935

Comment 12 Brett Thurber 2018-08-15 00:45:22 UTC
1613935 associated PR has been backported:  https://github.com/ManageIQ/manageiq/pull/17844

Moving to Post.

Comment 13 Kedar Kulkarni 2018-08-20 20:08:19 UTC
I could select Ansible Playbook Service Catalog Item to run on VM pre and post migration and it did execute the correct playbooks at correct time.