Bug 1610533

New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/e22387a84958be350f76052817be02e89a7ffab5
commit e22387a84958be350f76052817be02e89a7ffab5
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Jul 11 15:59:59 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Wed Jul 11 15:59:59 2018 -0400

    Merge pull request #17687 from bzwei/miq_request_cancel

    Support cancellation for miq_request and miq_request_task
    (cherry picked from commit d676ff58e41e587270f58efefaf4a01f173f6206)

    https://bugzilla.redhat.com/show_bug.cgi?id=1610533

 app/models/miq_request.rb | 8 +
 app/models/miq_request_task.rb | 8 +
 app/models/service_template_transformation_plan_request.rb | 10 +
 app/models/service_template_transformation_plan_task.rb | 9 +
 4 files changed, 35 insertions(+)

New commit detected on ManageIQ/manageiq-api/gaprindashvili:

https://github.com/ManageIQ/manageiq-api/commit/b7047744b21596fafe4cbfdc1064cad1fd8ba76c
commit b7047744b21596fafe4cbfdc1064cad1fd8ba76c
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Mon Jul 30 18:02:12 2018 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Mon Jul 30 18:02:12 2018 -0400

    Merge pull request #421 from bdunne/request_cancel

    Request cancel
    (cherry picked from commit 62de390490c8bc333f27feedfc58455ced1e7483)

    https://bugzilla.redhat.com/show_bug.cgi?id=1610533

 app/controllers/api/automation_requests_controller.rb | 1 +
 app/controllers/api/mixins/resource_cancel.rb | 14 +
 app/controllers/api/provision_requests_controller.rb | 1 +
 app/controllers/api/request_tasks_controller.rb | 1 +
 app/controllers/api/requests_controller.rb | 1 +
 app/controllers/api/service_requests_controller.rb | 1 +
 app/controllers/api/subcollections/request_tasks.rb | 7 +
 app/controllers/api/subcollections/service_requests.rb | 7 +
 config/api.yml | 31 +
 spec/requests/automation_requests_spec.rb | 12 +
 spec/requests/provision_requests_spec.rb | 12 +
 spec/requests/request_tasks_spec.rb | 7 +
 spec/requests/requests_spec.rb | 12 +
 spec/requests/service_orders_spec.rb | 6 +
 spec/requests/service_requests_spec.rb | 12 +
 spec/requests/service_templates_spec.rb | 6 +
 spec/support/api/helpers.rb | 8 +-
 spec/support/factory_overrides.rb | 23 +
 spec/support/shared_examples/resource_cancel.rb | 40 +
 spec/support/shared_examples/sub_resource_cancel.rb | 38 +
 20 files changed, 239 insertions(+), 1 deletion(-)

https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/525

https://bugzilla.redhat.com/show_bug.cgi?id=1599997 blocks this, as the cancellation does not guarantee of cleaning the Target Datastore or kill virt-v2v at the moment.

Pushing back to Assigned. As in 5.9.4.3 I am not able to cancel the migration successfully. CloudForms UI shows notification as "Migration Cancelled Successfully" , although, the timer and progress bar does not stop and migration is continued. On RHV I can also see disk size increasing and being transferred actively.

Created attachment 1474778 [details]
ScreenVideoRecording

Confirmed by Bill Wei that the options hash is cached and that parallel writes may create a race condition. First suggestion was to reload the object before using set_option in automate, but Bill considers that set_option should be fixed to prevent race condition.

The potential impact is high, so it has to be carefully weighed.

Associated BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1614864

Marco: Tomorrow (Aug 14) is the final 5.9.4 dev complete. Will this issue be resolved by then.

(In reply to John Prause from comment #10)
> Marco: Tomorrow (Aug 14) is the final 5.9.4 dev complete. Will this issue be
> resolved by then.

PR is merged and this is ready for backport.

On 5.9.4.4 I was able to cancel the migration successfully. Although it showed up as cancelled in CloudForms quickly, in the RHV Disks, it kept on migrating for some time before it was killed. It is not instantaneous.