Bug 1610729
Summary: | Remove migration plans from Service Catalog Items | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> | ||||||||||
Component: | UI - OPS | Assignee: | Hui Song <hsong> | ||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadnyawalk Tale <ytale> | ||||||||||
Severity: | high | Docs Contact: | |||||||||||
Priority: | high | ||||||||||||
Version: | 5.9.0 | CC: | bilwei, cpelland, gmccullo, hkataria, hsong, jprause, kkulkarn, lavenel, mpovolny, obarenbo, smallamp, ytale | ||||||||||
Target Milestone: | GA | Keywords: | ZStream | ||||||||||
Target Release: | 5.9.4 | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Whiteboard: | |||||||||||||
Fixed In Version: | 5.9.4.4 | Doc Type: | If docs needed, set a value | ||||||||||
Doc Text: | Story Points: | --- | |||||||||||
Clone Of: | 1594408 | Environment: | |||||||||||
Last Closed: | 2018-09-05 12:56:39 UTC | Type: | --- | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Bug Depends On: | 1594408 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Comment 2
CFME Bot
2018-08-01 10:21:10 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/24bc296be8024b360cb14837ac60e34d3c741c93 commit 24bc296be8024b360cb14837ac60e34d3c741c93 Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 31 18:24:17 2018 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 31 18:24:17 2018 -0400 Merge pull request #4274 from h-kataria/service_templates_to_exclude_migration_plans Changes to exclude service templates marked as service_type = internal (cherry picked from commit 3acd7630eadecd477892075a2d4b222a16547940) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729 app/controllers/catalog_controller.rb | 25 +- app/presenters/tree_builder_catalog_items.rb | 4 +- app/presenters/tree_builder_service_catalog.rb | 4 +- spec/controllers/catalog_controller_spec.rb | 6 +- 4 files changed, 23 insertions(+), 16 deletions(-) Created attachment 1474664 [details]
issue_5.9.4.3.mp4
Not fixed! I can still see plans in catalog_items, just that now it is little bit covered.
So earlier, plans were showing under catalog_item accordion in a tree (under Unassigned section) and now it is not showing in tree; but you can still find it with small extra steps, *click on `Unassigned`* and you will find plan are still there.
Also checked SSUI which is working as expected.
Checked on: 5.9.4.3.20180808144238_a20955a
Marking FailedQA as behavior is not expected.
(P.S. Video attached)
Created attachment 1474667 [details]
earlier_behavior_5.9.4.0.mp4
FYI, if you delete plan from catalog_item it actually deletes plan from migration page. New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/23574ded21541a4628e7aa05e0b8b8970f8b2fbd commit 23574ded21541a4628e7aa05e0b8b8970f8b2fbd Author: Dan Clarizio <dclarizi> AuthorDate: Tue Aug 14 12:36:20 2018 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Aug 14 12:36:20 2018 -0400 Merge pull request #4473 from h-kataria/exclude_migration_template_unassigned_folder Added missing 'public_service_templates' scope (cherry picked from commit 0b219e9248c8814caf0ed25831cbf69e41a2fcf7) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729 app/controllers/catalog_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Created attachment 1476602 [details]
5.9.4.4_proof.png
Fixed! Mentioned bug is patched and migration plans are not displaying in Unassigned catalog section (last time it was there).
Also in SSUI, service catalog don't show migration plan, which is what we have expected.
(My small concern is - ordered migration plan still get displayed in My Order section of SSUI but it is covering through another Bugzilla issue so verifying this issue)
Verified on: 5.9.4.4.20180816162527_c00eb23
Created attachment 1476603 [details]
My_Order_SSUI.png
New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/296d94413596d44908c5849a974ed6b3be9693f9 commit 296d94413596d44908c5849a974ed6b3be9693f9 Author: hsong-rh <hsong> AuthorDate: Fri Aug 10 11:22:34 2018 -0400 Commit: hsong-rh <hsong> CommitDate: Fri Aug 10 11:22:34 2018 -0400 Update default of internal attribute in service template https://bugzilla.redhat.com/show_bug.cgi?id=1610729 db/migrate/20180810144738_update_default_internal_attribute.rb | 11 + spec/migrations/20180810144738_update_default_internal_attribute_spec.rb | 23 + 2 files changed, 34 insertions(+) |