Bug 1611589
| Summary: | Need to use {} around the environment variables in unit files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian J. Murrell <brian> | ||||
| Component: | quagga | Assignee: | Michal Ruprich <mruprich> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 28 | CC: | balajig81, bennie.joubert, jaskalnik, mruprich, msekleta, rjones | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | quagga-1.2.4-2.fc28 quagga-1.2.4-4.fc29 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-12-21 05:52:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1607348 | ||||||
| Attachments: |
|
||||||
Reported upstream along with patch. I am now discussing my proposed patch with upstream developer. Created attachment 1477444 [details]
Patch
The fix is not yet in upstream but I have spoken to them and they approved it. The upstream is kind of inactive so it might not get into any github repo any time soon. But This behaviour was disrupting the start-up of quagga daemons on Fedora so I decided to move forward with this. Can confirm that quagga-1.2.4-4.fc30 works, thanks. quagga-1.2.4-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. quagga-1.2.4-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Without the ${VARIABLE} syntax the variables are not properly expanded and chown ends up returning an error. Version-Release number of selected component (if applicable): quagga-1.2.4-1.fc28.x86_64 How reproducible: 100% Steps to Reproduce: 1. Install and configure quagga with OSPF 2. Start the unit Actual results: Aug 02 08:01:28 pc.interlinx.bc.ca systemd[1]: Starting OSPF routing daemon... Aug 02 08:01:28 pc.interlinx.bc.ca chown[11949]: /bin/chown: missing operand after ‘/etc/quagga/ospfd.conf’ Aug 02 08:01:28 pc.interlinx.bc.ca chown[11949]: Try '/bin/chown --help' for more information. Aug 02 08:01:28 pc.interlinx.bc.ca systemd[1]: Started OSPF routing daemon. Expected results: chown should not report an error Additional info: Bug filed upstream at https://bugzilla.quagga.net/show_bug.cgi?id=993 and PR filed at https://github.com/Quagga/quagga/pull/3.