Bug 1611589 - Need to use {} around the environment variables in unit files
Summary: Need to use {} around the environment variables in unit files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: quagga
Version: 28
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Michal Ruprich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1607348
TreeView+ depends on / blocked
 
Reported: 2018-08-02 12:21 UTC by Brian J. Murrell
Modified: 2018-12-21 19:39 UTC (History)
6 users (show)

Fixed In Version: quagga-1.2.4-2.fc28 quagga-1.2.4-4.fc29
Clone Of:
Environment:
Last Closed: 2018-12-21 05:52:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch (5.07 KB, patch)
2018-08-21 08:05 UTC, Michal Ruprich
no flags Details | Diff

Description Brian J. Murrell 2018-08-02 12:21:50 UTC
Description of problem:
Without the ${VARIABLE} syntax the variables are not properly expanded and chown
ends up returning an error.

Version-Release number of selected component (if applicable):
quagga-1.2.4-1.fc28.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Install and configure quagga with OSPF
2. Start the unit

Actual results:
Aug 02 08:01:28 pc.interlinx.bc.ca systemd[1]: Starting OSPF routing daemon...
Aug 02 08:01:28 pc.interlinx.bc.ca chown[11949]: /bin/chown: missing operand after ‘/etc/quagga/ospfd.conf’
Aug 02 08:01:28 pc.interlinx.bc.ca chown[11949]: Try '/bin/chown --help' for more information.
Aug 02 08:01:28 pc.interlinx.bc.ca systemd[1]: Started OSPF routing daemon.

Expected results:
chown should not report an error

Additional info:
Bug filed upstream at https://bugzilla.quagga.net/show_bug.cgi?id=993 and PR filed at https://github.com/Quagga/quagga/pull/3.

Comment 1 Michal Ruprich 2018-08-21 08:03:22 UTC
Reported upstream along with patch. I am now discussing my proposed patch with upstream developer.

Comment 2 Michal Ruprich 2018-08-21 08:05:37 UTC
Created attachment 1477444 [details]
Patch

Comment 3 Michal Ruprich 2018-12-10 12:27:58 UTC
The fix is not yet in upstream but I have spoken to them and they approved it. The upstream is kind of inactive so it might not get into any github repo any time soon. But This behaviour was disrupting the start-up of quagga daemons on Fedora so I decided to move forward with this.

Comment 4 Richard W.M. Jones 2018-12-10 16:07:50 UTC
Can confirm that quagga-1.2.4-4.fc30 works, thanks.

Comment 5 Fedora Update System 2018-12-21 05:52:34 UTC
quagga-1.2.4-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2018-12-21 19:39:20 UTC
quagga-1.2.4-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.