Bug 1611617

Summary: On rollback of failed upgrade from 4.2.1+, engine-setup outputs errors about the uuid-ossp extension
Product: Red Hat Enterprise Virtualization Manager Reporter: Thom Carlin <tcarlin>
Component: ovirt-engineAssignee: Eli Mesika <emesika>
Status: CLOSED ERRATA QA Contact: Lucie Leistnerova <lleistne>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.2.5CC: bcholler, didi, eedri, emesika, gianluca.cecchi, gveitmic, lsurette, lsvaty, mkalinin, mperina, Rhev-m-bugs, srevivo, tburke
Target Milestone: ovirt-4.3.0Keywords: Regression, ZStream
Target Release: 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1613168 (view as bug list) Environment:
Last Closed: 2019-05-08 12:38:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1724792, 1613168    

Description Thom Carlin 2018-08-02 13:25:40 UTC
Description of problem:

Upgrade aborts with "ERROR: must be owner of extension plpgsql during Restoring DWH database ovirt_engine_history"

Version-Release number of selected component (if applicable):

4.2.4/4.2.5

How reproducible:

100% in my environment

Steps to Reproduce:
1. engine-setup
2. Take defaults for all except add full vacuum

Actual results:

ERROR: must be owner of extension plpgsql during Restoring DWH database ovirt_engine_history 

Expected results:

Successful upgrade

Additional info:

Comment 2 Sandro Bonazzola 2018-08-02 13:30:27 UTC
Eli, can you please look into this?

Comment 8 Yedidyah Bar David 2018-08-07 06:08:05 UTC
1. The bug is about errors from pg_restore, which is ran during _rollback_. So to reproduce, you have to cause engine-setup to fail somehow (bug 1609839, in this case, but can be anything).

2. engine-setup already filters out some errors from pg_restore, which we decided are harmless. These are logged but are not shown to the user.

3. Unfiltered errors are also shown to the user, and it's up to the user to decide if that's a problem or not. Other than that, it continues as usual. So if the user decided that the errors are harmless, nothing else needs to be done (other than handling the original cause for rollback and then trying to upgrade again).

4. In this case, the unfiltered errors are:

otopi.ovirt_engine_setup.engine_common.database database.restore:942 Errors unfiltered during restore:

pg_restore: [archiver (db)] Error from TOC entry 7310; 0 0 COMMENT EXTENSION "uuid-ossp"
pg_restore: [archiver (db)] could not execute query: ERROR:  must be owner of extension uuid-ossp

5. I am pretty certain that they are harmless. Also pushed a patch (93544) to add them to the filtered errors. If Eli agrees, that's enough.

6. Also, since they seem harmless to me, lowered priority/severity accordingly.

7. Also changing the summary line according to (1.) and (4.). uuid-ossp was introduced in bug 1515635, 4.2.1.

Comment 14 Lucie Leistnerova 2018-09-06 07:32:16 UTC
I aborted engine-setup with otopi-debug-plugins

OTOPI_FORCE_FAIL_STAGE=STAGE_MISC OTOPI_FORCE_FAIL_PRIORITY=PRIORITY_LOW engine-setup

and rollback was successfull

verified in ovirt-engine-4.3.0-0.0.master.20180902070649.gita860c9c.el7.noarch
with ovirt-engine-setup-plugin-ovirt-engine-common-4.3.0-0.0.master.20180903111244.git94dce75.el7.noarch

Comment 16 errata-xmlrpc 2019-05-08 12:38:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1085

Comment 17 Daniel Gur 2019-08-28 13:11:58 UTC
sync2jira

Comment 18 Daniel Gur 2019-08-28 13:16:10 UTC
sync2jira