Red Hat Bugzilla – Bug 1611617
On rollback of failed upgrade from 4.2.1+, engine-setup outputs errors about the uuid-ossp extension
Last modified: 2018-09-06 03:32:16 EDT
Description of problem: Upgrade aborts with "ERROR: must be owner of extension plpgsql during Restoring DWH database ovirt_engine_history" Version-Release number of selected component (if applicable): 4.2.4/4.2.5 How reproducible: 100% in my environment Steps to Reproduce: 1. engine-setup 2. Take defaults for all except add full vacuum Actual results: ERROR: must be owner of extension plpgsql during Restoring DWH database ovirt_engine_history Expected results: Successful upgrade Additional info:
Eli, can you please look into this?
1. The bug is about errors from pg_restore, which is ran during _rollback_. So to reproduce, you have to cause engine-setup to fail somehow (bug 1609839, in this case, but can be anything). 2. engine-setup already filters out some errors from pg_restore, which we decided are harmless. These are logged but are not shown to the user. 3. Unfiltered errors are also shown to the user, and it's up to the user to decide if that's a problem or not. Other than that, it continues as usual. So if the user decided that the errors are harmless, nothing else needs to be done (other than handling the original cause for rollback and then trying to upgrade again). 4. In this case, the unfiltered errors are: otopi.ovirt_engine_setup.engine_common.database database.restore:942 Errors unfiltered during restore: pg_restore: [archiver (db)] Error from TOC entry 7310; 0 0 COMMENT EXTENSION "uuid-ossp" pg_restore: [archiver (db)] could not execute query: ERROR: must be owner of extension uuid-ossp 5. I am pretty certain that they are harmless. Also pushed a patch (93544) to add them to the filtered errors. If Eli agrees, that's enough. 6. Also, since they seem harmless to me, lowered priority/severity accordingly. 7. Also changing the summary line according to (1.) and (4.). uuid-ossp was introduced in bug 1515635, 4.2.1.
I aborted engine-setup with otopi-debug-plugins OTOPI_FORCE_FAIL_STAGE=STAGE_MISC OTOPI_FORCE_FAIL_PRIORITY=PRIORITY_LOW engine-setup and rollback was successfull verified in ovirt-engine-4.3.0-0.0.master.20180902070649.gita860c9c.el7.noarch with ovirt-engine-setup-plugin-ovirt-engine-common-4.3.0-0.0.master.20180903111244.git94dce75.el7.noarch