Bug 1613326

Summary:	[RHV] ISO provisioning fails with undefined SDK method
Product:	Red Hat CloudForms Management Engine	Reporter:	Jan Zmeskal <jzmeskal>
Component:	Providers	Assignee:	Boriso <bodnopoz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jan Zmeskal <jzmeskal>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.9.4	CC:	bodnopoz, dmetzger, gblomqui, istein, jfrey, jhardy, jprause, mperina, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.10.0.20	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1637185 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:53:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	RHEVM	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1637185

Description Jan Zmeskal 2018-08-07 12:14:01 UTC

Description of problem:
CFME supports ISO provisioning on RHV provider. During this process, Kickstart file payload is propagated to the provisioned VM by means of attaching floppy. If you actually try to do ISO provisioning, you request will fail with:
[NoMethodError]: undefined method `attach_floppy'

Version-Release number of selected component (if applicable):
CFME 5.9.4.2
RHV 4.2.5
rh-ruby23-rubygem-ovirt-engine-sdk4 4.2.1

How reproducible:
100 %

Steps to Reproduce:
1. Basically all you need to do is to follow CFME documentation on ISO provisioning. However, some months ago, I found it quite lacking. That's why I created this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1584675
2. At the present moment, however, there is an updated version of the process. At the moment of me writing this, it is in a form of GitHub PR: https://github.com/ManageIQ/manageiq_docs/pull/922. It might also be merged soon and available here: 
https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.6/html-single/provisioning_virtual_machines_and_hosts/#iso-provisioning
Anyway, all you need to know is to follow the documentation.
3. Once you finish step 2.7 Adding a Customization Template (https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.6/html-single/provisioning_virtual_machines_and_hosts/#adding-a-customization-template), try to provision new VM from you ISO image.
4. Be sure to set these thing in provisioning form:
Catalog -> Provision Type == ISO
ISO -> Image == <your_modified_image>
Customize -> Customize Template -> Script Name == <your_kickstart_script>
Schedule -> Lifespan -> Power on virtual machines after creation == False
5. Wait for the provision request to complete.

Actual results:
Provisioning request fails with this error:
[EVM] VM [installing_modified_iso] Step [CheckProvisioned] Status [Error Creating VM] Message [[NoMethodError]: undefined method `attach_floppy' for #<OvirtSDK4::VmService:vms/d016bfdc-c6b2-4a91-bd36-bd577cc48996>]

Expected results:
I would expect the request to succeed when following documentation. Or at least fail with helpful error message.

Additional info:
- Attached is evm.log. You can search for VM called "installing_modified_iso". That's the VM I tried to provision.
- If you are using RHEL7.5 as a provisioned VM's OS, you can use attached kickstart file. I obtained it simply by installing RHEL manually and then copying anaconda-ks.cfg from it. You can also do the same if you want to - it's probably the easiest way how to quickly get working Kickstart file.

Comment 5 Jan Zmeskal 2018-08-07 13:10:01 UTC

Additional info: 
I tried creating VM using the same Kickstart file as is used in Customization template in RHV. It worked without problems.

Jan

Comment 6 Ilanit Stein 2018-08-12 10:50:35 UTC

Martin, 

Is this bug about missing adaptation to APIv4 please?

Thanks.

Comment 7 Martin Perina 2018-08-21 06:56:32 UTC

Boris, could you please take a look?

Comment 14 Ilanit Stein 2018-10-11 10:39:40 UTC

Moving qe_test_coverage to + as there is already automation in place for the VM provision from ISO flow (which actually revealed this bug).

Comment 15 Satoe Imaishi 2018-10-11 13:26:37 UTC

https://github.com/ManageIQ/manageiq-providers-ovirt/pull/298

Comment 16 CFME Bot 2018-10-11 14:29:01 UTC

New commits detected on ManageIQ/manageiq-providers-ovirt/hammer:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/8a8e85a0be27f45707a873deb1fe828ea2a91682
commit 8a8e85a0be27f45707a873deb1fe828ea2a91682
Author:     Piotr Kliczewski <piotr.kliczewski>
AuthorDate: Mon Oct  8 10:13:46 2018 -0400
Commit:     Piotr Kliczewski <piotr.kliczewski>
CommitDate: Mon Oct  8 10:13:46 2018 -0400

    Merge pull request #296 from borod108/bugs/1613326iso_prov

    Fix ISO provisioning with kickstart

    (cherry picked from commit 9d27961b57a542a3259984fdd436d0a25c187435)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613326

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 10 +
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration_spec.rb | 39 +-
 2 files changed, 44 insertions(+), 5 deletions(-)


https://github.com/ManageIQ/manageiq-providers-ovirt/commit/55fa5965245121a0e1e7451a0e844d4d4405158f
commit 55fa5965245121a0e1e7451a0e844d4d4405158f
Author:     Piotr Kliczewski <piotr.kliczewski>
AuthorDate: Wed Oct 10 10:42:36 2018 -0400
Commit:     Piotr Kliczewski <piotr.kliczewski>
CommitDate: Wed Oct 10 10:42:36 2018 -0400

    Merge pull request #298 from borod108/bugs/1613326iso_prov_2

    Fix attach_floppy to pass "floppy" type

    (cherry picked from commit db724df0af9fe3e9dd8fbb136807c2967cbc3cbd)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613326

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 2 +-
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration_spec.rb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 17 CFME Bot 2018-10-11 14:29:20 UTC

New commits detected on ManageIQ/manageiq-providers-ovirt/master:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/d29a69676f1d44128b681ba1ec8901df0146c9ed
commit d29a69676f1d44128b681ba1ec8901df0146c9ed
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Sun Oct  7 10:45:29 2018 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Sun Oct  7 10:45:29 2018 -0400

    Fix ISO provisioning with kickstart

    Provisioning with kickstart was not implemented for version 4 of the
    api.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1613326

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 10 +
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration_spec.rb | 39 +-
 2 files changed, 44 insertions(+), 5 deletions(-)


https://github.com/ManageIQ/manageiq-providers-ovirt/commit/935fd32bff202de8c285a85cfc30b2992cc22768
commit 935fd32bff202de8c285a85cfc30b2992cc22768
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Wed Oct 10 09:42:52 2018 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Wed Oct 10 09:42:52 2018 -0400

    Fix attach_floppy to pass "floppy" type

    The type of the payload was not passed.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1613326

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 2 +-
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration_spec.rb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)