Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1613647

Summary: registry-console is not deployed on to master node.
Product: OpenShift Container Platform Reporter: Johnny Liu <jialiu>
Component: InstallerAssignee: Michael Gugino <mgugino>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.11.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: 3.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-11 07:24:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Johnny Liu 2018-08-08 04:35:52 UTC 
Description of problem:
According to https://bugzilla.redhat.com/show_bug.cgi?id=1425022#c16, registry-console pod would be deployed on to master node by default, but in 3.11, it is not.

# oc get po registry-console-1-nqh9r  -o wide
NAME                       READY     STATUS    RESTARTS   AGE       IP         NODE                            NOMINATED NODE
registry-console-1-nqh9r   1/1       Running   0          16h       11.0.4.3   qe-jialiu311-auto-ivps-node-1   <none>

# oc get node
NAME                                   STATUS    ROLES     AGE       VERSION
qe-jialiu311-auto-ivps-master-etcd-1   Ready     master    16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-master-etcd-2   Ready     master    16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-master-etcd-3   Ready     master    16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-node-1          Ready     compute   16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-nrr-1           Ready     <none>    16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-nrr-2           Ready     <none>    16h       v1.11.0+d4cacc0
qe-jialiu311-auto-ivps-nrr-3           Ready     <none>    16h       v1.11.0+d4cacc0

After check registry-console dc, no nodeSelector is set.

Trace openshift-ansible code, found nodeSelector setting is missing in 3.11 registry-console template:
$ diff ./roles/openshift_hosted_templates/files/v3.11/enterprise/registry-console.yaml ./roles/openshift_hosted_templates/files/v3.10/enterprise/registry-console.yaml
27a28,29
>           nodeSelector:
>             node-role.kubernetes.io/master: 'true'
98c100
<     value: "v3.11"
---
>     value: "v3.10"


Version-Release number of the following components:
openshift-ansible-3.11.0-0.11.0.git.0.3c66516None.noarch

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag
Comment 1 Scott Dodson 2018-08-08 12:44:17 UTC 
Mike,

When refactoring this code to collapse it into cockpit-ui can you make sure there's one common template and it's got the proper node selector?
Comment 2 Michael Gugino 2018-08-08 14:55:25 UTC 
(In reply to Scott Dodson from comment #1)
> Mike,
> 
> When refactoring this code to collapse it into cockpit-ui can you make sure
> there's one common template and it's got the proper node selector?

Yes, I can add that to the template.
Comment 3 Michael Gugino 2018-08-09 23:03:02 UTC 
PR Created: https://github.com/openshift/openshift-ansible/pull/9447
Comment 5 Johnny Liu 2018-08-23 06:58:50 UTC 
Verified this bug with openshift-ansible-3.11.0-0.20.0.git.0.ec6d8caNone.noarch, and PASS.

[root@qe-wzheng-master-etcd-1 ~]# oc get dc registry-console -o yaml|grep nodeSele -A 3
      nodeSelector:
        node-role.kubernetes.io/master: "true"
      restartPolicy: Always
      schedulerName: default-scheduler

[root@qe-wzheng-master-etcd-1 ~]# oc get po registry-console-1-6tqfx -o wide
NAME                       READY     STATUS    RESTARTS   AGE       IP           NODE                      NOMINATED NODE
registry-console-1-6tqfx   1/1       Running   0          20m       10.128.0.3   qe-wzheng-master-etcd-1   <none>
Comment 7 errata-xmlrpc 2018-10-11 07:24:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652