Bug 1614361

Summary: [RFE][Improvement][FFU]System should not reboot if there's no changes to KernelArgs that require a reboot
Product: Red Hat OpenStack Reporter: Darin Sorrentino <dsorrent>
Component: openstack-tripleo-heat-templatesAssignee: Saravanan KR <skramaja>
Status: CLOSED ERRATA QA Contact: Yariv <yrachman>
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: amcleod, asonmez, atelang, ccamacho, cfontain, dvd, hbrock, jpichon, jslagle, lbezdick, marjones, mbultel, mburns, ndeevy, sclewis, sgolovat, skramaja, slinaber, supadhya, yroblamo
Target Milestone: z8Keywords: FutureFeature, Reopened, TestOnly, Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.3.1-2.el7ost Doc Type: Enhancement
Doc Text:
With this update, you can now use the Red Hat OpenStack Platform 13 host-config-and-reboot environment during fast-forward upgrade: 1. Remove the `NodeUserData` mapping from the `first-boot` script 2. Add the `host-config-and-reboot.yaml` environment file to the deploy command 3. Add KernelArgs and TunedProfile configured to the OvS-DPDK role using role-specific parameters 4. Ensure that the KernelArgs and TunedProfile correspond to the OpenStack Platform 10 values. Any changes result in the node rebooting during fast-forward upgrade and the upgrade fails. Ansible cannot handle reboots performed by the heat stack configuration. Any incorrect configuration that results in reboot causes the fast-forward upgrade process to fail. [NOTE] You can still perform the fast-forward upgrade with the existing first-boot scripts, even with the new patches present.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-03 16:55:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1692838, 1702767, 1709893, 1714205    
Bug Blocks:    
Attachments:
Description Flags
FFU-diff-THT none

Description Darin Sorrentino 2018-08-09 13:42:54 UTC 
Description of problem:

During FFU upgrade, we were using template:

/usr/share/openstack-tripleo-heat-templates/extraconfig/pre_network/host_config_and_reboot.yaml

And it looks like it will reboot even if there are no changes in the KernelArgs.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Yolanda Robla 2018-08-09 13:47:14 UTC 
So far, we detected that there was a kernel change that was causing the reboot:

ControllerParameters:
    KernelArgs: "systemd.show_status=yes"

This parameter was not there, before this environment was added.

However, it is pending to test if, having the server same parameters in KernelArgs, will it be rebooted or not.
Comment 2 Darin Sorrentino 2018-08-09 14:09:27 UTC 
Talking to Lukas, he said that it doesn't matter if the values changed or not, the code will reboot on the presence of KernelArgs.
Comment 3 Saravanan KR 2018-08-10 03:45:14 UTC 
(In reply to Darin Sorrentino from comment #2)
> Talking to Lukas, he said that it doesn't matter if the values changed or
> not, the code will reboot on the presence of KernelArgs.

Yes, it will not check for existing parameters to reboot. It depends on the stack create or update to decide on the reboot. I believe it is good enhancement to add this check.

This enhancement is already added to the config-download based deployments in master [1] by checking existing values. For non-config download deployments, this has to be added within the reboot resource.

[1] https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/pre_network/boot-params-service.yaml#L94
Comment 8 Lukas Bezdicka 2018-10-08 10:35:48 UTC 
I think I wanted to see this code - https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/pre_network/boot_param_tasks.yaml#L10#L50 which means this was solved.
Comment 29 Sanjay Upadhyay 2019-06-19 12:05:27 UTC 
upgrades (OSP10, 13, 14) affected by python-websocket controversy/breakage, escalation: https://trello.com/c/Hs1QbfRM
Comment 31 Yariv 2019-08-29 15:57:10 UTC 
Created attachment 1609499 [details]
FFU-diff-THT
Comment 32 Yariv 2019-08-29 16:00:02 UTC 
Verified,
with the following builds
10z passed_phase2, OpenStack-10.0-RHEL-7-20190816.1
to 13z latest, 2019-08-27.2

See diff attachment https://bugzilla.redhat.com/attachment.cgi?id=1609499
systemctl status ovs-vswitchd
● ovs-vswitchd.service - Open vSwitch Forwarding Unit
   Loaded: loaded (/usr/lib/systemd/system/ovs-vswitchd.service; static; vendor preset: disabled)
   Active: active (running) since Tue 2019-08-27 13:46:41 UTC; 2 days ago
 Main PID: 10193 (ovs-vswitchd)

Already up.
Comment 34 errata-xmlrpc 2019-09-03 16:55:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2624