Description of problem: During FFU upgrade, we were using template: /usr/share/openstack-tripleo-heat-templates/extraconfig/pre_network/host_config_and_reboot.yaml And it looks like it will reboot even if there are no changes in the KernelArgs. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
So far, we detected that there was a kernel change that was causing the reboot: ControllerParameters: KernelArgs: "systemd.show_status=yes" This parameter was not there, before this environment was added. However, it is pending to test if, having the server same parameters in KernelArgs, will it be rebooted or not.
Talking to Lukas, he said that it doesn't matter if the values changed or not, the code will reboot on the presence of KernelArgs.
(In reply to Darin Sorrentino from comment #2) > Talking to Lukas, he said that it doesn't matter if the values changed or > not, the code will reboot on the presence of KernelArgs. Yes, it will not check for existing parameters to reboot. It depends on the stack create or update to decide on the reboot. I believe it is good enhancement to add this check. This enhancement is already added to the config-download based deployments in master [1] by checking existing values. For non-config download deployments, this has to be added within the reboot resource. [1] https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/pre_network/boot-params-service.yaml#L94
I think I wanted to see this code - https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/pre_network/boot_param_tasks.yaml#L10#L50 which means this was solved.
upgrades (OSP10, 13, 14) affected by python-websocket controversy/breakage, escalation: https://trello.com/c/Hs1QbfRM
Created attachment 1609499 [details] FFU-diff-THT
Verified, with the following builds 10z passed_phase2, OpenStack-10.0-RHEL-7-20190816.1 to 13z latest, 2019-08-27.2 See diff attachment https://bugzilla.redhat.com/attachment.cgi?id=1609499 systemctl status ovs-vswitchd ● ovs-vswitchd.service - Open vSwitch Forwarding Unit Loaded: loaded (/usr/lib/systemd/system/ovs-vswitchd.service; static; vendor preset: disabled) Active: active (running) since Tue 2019-08-27 13:46:41 UTC; 2 days ago Main PID: 10193 (ovs-vswitchd) Already up.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2624