Bug 162136
| Summary: | comparisons like X<=Y<=Z do not have their mathematical meaning | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> | ||||
| Component: | evolution | Assignee: | Dave Malcolm <dmalcolm> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-10-17 21:28:02 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 150221 | ||||||
| Attachments: |
|
||||||
Thanks for this report. I agree that this code looks suspect. I'll try to get this fixed upstream. Bug still present in latest version in CVS, and in latest rawhide package. Created attachment 117882 [details]
Patch sent upstream
I fixed this in upstream CVS on August 22; this fix is in 2.3.8 and later |
Description of problem: I just tried to compile package evolution-2.2.2-5 from Redhat Fedora Core development tree with the gcc 4.0.0 compiler and the compiler flag -Wall. The compiler said e-plugin.c:93: warning: comparisons like X<=Y<=Z do not have their mathematical meaning The source code is if ((state == 0) == ep_check_enabled(id) == 0) return; This is really bizarre code. Suggest code rework for maintainability. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: