Bug 162136 - comparisons like X<=Y<=Z do not have their mathematical meaning
comparisons like X<=Y<=Z do not have their mathematical meaning
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: evolution (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dave Malcolm
:
Depends On:
Blocks: FC5Target
  Show dependency treegraph
 
Reported: 2005-06-30 05:45 EDT by David Binderman
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-10-17 17:28:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Patch sent upstream (1.13 KB, patch)
2005-08-18 16:44 EDT, Dave Malcolm
no flags Details | Diff

  None (edit)
Description David Binderman 2005-06-30 05:45:44 EDT
Description of problem:

I just tried to compile package evolution-2.2.2-5 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

e-plugin.c:93: warning: comparisons like X<=Y<=Z do not have their mathematical
meaning

The source code is

        if ((state == 0) == ep_check_enabled(id) == 0)
                return;

This is really bizarre code. Suggest code rework for maintainability.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Dave Malcolm 2005-08-17 23:29:15 EDT
Thanks for this report.  I agree that this code looks suspect.  I'll try to get
this fixed upstream.
Comment 2 Dave Malcolm 2005-08-18 16:24:23 EDT
Bug still present in latest version in CVS, and in latest rawhide package.
Comment 3 Dave Malcolm 2005-08-18 16:44:23 EDT
Created attachment 117882 [details]
Patch sent upstream
Comment 4 Dave Malcolm 2005-10-17 17:28:02 EDT
I fixed this in upstream CVS on August 22; this fix is in 2.3.8 and later

Note You need to log in before you can comment on or make changes to this bug.