Bug 1622000

Summary: mutter overrides xorg.conf [rhel-7.5.z]
Product: Red Hat Enterprise Linux 7 Reporter: Oneata Mircea Teodor <toneata>
Component: mutterAssignee: Florian Müllner <fmuellner>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact: Adam Kvitek <akvitek>
Priority: urgent    
Version: 7.5CC: akvitek, alanm, amike, aubin.guillemette, cww, dereks, fmuellner, jwright, michael.facciani, mkolbas, thudziec, toneata, tpelka
Target Milestone: rcKeywords: Regression, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: mutter-3.26.2-17.el7_5 Doc Type: Bug Fix
Doc Text:
Previously, the mutter configuration overrode the monitor layouts defined by the xorg.conf file. This update fixes an error in the mutter compositor, and the correct monitor layout is now used.
Story Points: ---
Clone Of: 1585230 Environment:
Last Closed: 2018-09-25 19:10:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1585230    
Bug Blocks:    
Attachments:
Description Flags
file /etc/X11/xorg.conf none

Description Oneata Mircea Teodor 2018-08-24 06:27:12 UTC
This bug has been copied from bug #1585230 and has been proposed to be backported to 7.5 z-stream (EUS).

Comment 3 Tomas Pelka 2018-08-27 06:20:03 UTC
*** Bug 1594392 has been marked as a duplicate of this bug. ***

Comment 5 Tomas Hudziec 2018-09-04 17:40:18 UTC
I did not manage to reproduce it on RHEL 7.5 even with affected version of mutter - 3.26.2-13.el7.x86_64.

After setting some screen resolution in /etc/X11/xorg.conf and restarting GUI, the resolution is being set, so xorg.conf is not overriden by mutter.

Comment 6 Tomas Hudziec 2018-09-04 17:44:46 UTC
Created attachment 1480856 [details]
file /etc/X11/xorg.conf

xorg.conf generated with
# Xorg :3 -configure
and added line 'Modes "1024x768"' to Screen section
I did not manage to reproduce the bug with that xorg.conf.

Comment 7 Derek Schrock 2018-09-04 19:38:28 UTC
I don't believe this is the proper test for this issue.  From my experience the issue is with display layout not display resolution.

A simple test would be create a 2x1 display output then see if mutter reconfigures this to be a 1xN (1x2 in this case).

Comment 8 Florian Müllner 2018-09-04 21:35:30 UTC
(In reply to Derek Schrock from comment #7)
> From my experience the issue is with display layout not display resolution.

That's correct, thanks for the hint.

Comment 9 Tomas Hudziec 2018-09-05 12:42:24 UTC
Ok, thanks for the hint. I have set some monitor layout in xorg.conf. It works and it is not overriden by mutter-3.26.2-16 if there is no file ~/.config/monitors.xml (from gnome-control-center).

But if there exists file ~/.config/monitors.xml, layout in the xorg.conf is present only in gdm and in desktop is overriden by that in monitors.xml.

Is it correct behaviour? Should ~/.config/monitors.xml have priority before /etc/X11/xorg.conf regarding monitors layout?

Comment 10 Florian Müllner 2018-09-05 12:49:23 UTC
(In reply to Tomas Hudziec from comment #9)
> Is it correct behaviour? Should ~/.config/monitors.xml have priority before
> /etc/X11/xorg.conf regarding monitors layout?

Yes, if the user uses the display settings to change the layout, that should have precedence over the default layout.

Comment 11 Tomas Hudziec 2018-09-05 13:17:41 UTC
(In reply to Florian Müllner from comment #10)
> Yes, if the user uses the display settings to change the layout, that should
> have precedence over the default layout.

Ok, then it works correctly with mutter-3.26.2-16.

But I had no luck to reproduce the overriding layout in xorg.conf by mutter-3.26.2-13.
I have following sections in my xorg.conf:
Section "Monitor"
    Identifier  "DP-2"
EndSection

Section "Monitor"
    Identifier  "DP-3"
    Option      "Primary" "true"
    Option      "LeftOf" "DP-2"
EndSection

How should I reproduce the bug? Do I have to use some Nvidia proprietary module mentioned in the original bug 1585230?

Comment 12 Tomas Pelka 2018-09-05 13:48:54 UTC
(In reply to Tomas Hudziec from comment #11)
> (In reply to Florian Müllner from comment #10)
> > Yes, if the user uses the display settings to change the layout, that should
> > have precedence over the default layout.
> 
> Ok, then it works correctly with mutter-3.26.2-16.
> 
> But I had no luck to reproduce the overriding layout in xorg.conf by
> mutter-3.26.2-13.
> I have following sections in my xorg.conf:
> Section "Monitor"
>     Identifier  "DP-2"
> EndSection
> 
> Section "Monitor"
>     Identifier  "DP-3"
>     Option      "Primary" "true"
>     Option      "LeftOf" "DP-2"
> EndSection
> 
> How should I reproduce the bug? Do I have to use some Nvidia proprietary
> module mentioned in the original bug 1585230?

Tomas if I may. We might be able to verify as it is working now, who knows under what conditions it was reproduced originally. Moreover the hotfix was confirmed by customer if I'm not mistaken.

Objections Florian?

Comment 13 Florian Müllner 2018-09-05 14:03:54 UTC
(In reply to Tomas Hudziec from comment #11)
> How should I reproduce the bug? Do I have to use some Nvidia proprietary
> module mentioned in the original bug 1585230?

No, this shouldn't be Nvidia-specific - for example I tested on intel when writing the original patch.

It's simply possible that your test configuration happens to match the layout that mutter uses as fallback if no configuration is found. As mutter's fallback is always a horizontal layout, I found that a vertical layout makes for a good test case.

Comment 14 Florian Müllner 2018-09-05 14:06:34 UTC
(In reply to Tomas Pelka from comment #12)
> Objections Florian?

No, not at all - the important thing is that the issue is fixed for the customer, which seems to be the case.

Comment 15 Tomas Hudziec 2018-09-05 15:26:21 UTC
(In reply to Florian Müllner from comment #13)
> It's simply possible that your test configuration happens to match the
> layout that mutter uses as fallback if no configuration is found.

Yes, it was the case.

> As mutter's fallback is always a horizontal layout, I found that a vertical
> layout makes for a good test case.

With vertical layout I reproduced the issue, mutter-3.26.2-13 sets the layout back to horizontal. Vertical layout stays with mutter-3.26.2-16, which is correct. Switching to verified finally. Apologies for upset.

Comment 20 errata-xmlrpc 2018-09-25 19:10:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2765